Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the SFINAE check with static_assert [13.0.x] #42427

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 31, 2023

PR description:

Works around a rare bug in nvcc/gcc that causes a function-static variable to be emitted as a local symbol instead of a unique global symbol.

PR validation:

Adding these changes on top of a setup that is failing as described in #42414 prevents the crash at the end of the job.

PR backports:

Backport of #42425 to 13.0.x to fix Alpaka-related developments and workflows.

Works around a rare bug in nvcc/gcc that causes a function-static
variable to be emitted as a local symbol instead of a unique global
symbol.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_0_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 31, 2023

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 31, 2023

backport #42425

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 31, 2023

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fac73/33983/summary.html
COMMIT: 5a3261a
CMSSW: CMSSW_13_0_X_2023-07-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42427/33983/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 62 lines from the logs
  • Reco comparison results: 343 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3281270
  • DQMHistoTests: Total failures: 56
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3281192
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 1, 2023

I assume the cms/42426/el8_amd64_gcc11/relvals/input errors are unrelated to this PR.

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 1, 2023

please test

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fac73/34013/summary.html
COMMIT: 5a3261a
CMSSW: CMSSW_13_0_X_2023-08-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42427/34013/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 29 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3281270
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3281240
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

merge

@cmsbuild cmsbuild merged commit 55755bf into cms-sw:CMSSW_13_0_X Aug 1, 2023
@fwyzard fwyzard deleted the replace_SFINAE_check_with_static_assert branch August 13, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants