Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update showerParams.py in L1Trigger/CSCTriggerPrimitives [backport to CMSSW_13_0_X] #42548

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

fmanteca
Copy link
Contributor

PR description:

Update Muon Shower Trigger loose thresholds to match the thresholds in firmware deployed at p5 on June 23rd: https://its.cern.ch/jira/browse/CMSLITDPG-1169

PR validation:

https://its.cern.ch/jira/browse/CMSLITDPG-1087

https://its.cern.ch/jira/browse/CMSHLT-2871

Backport to CMSSW_13_0_X. Original PR: #42485

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2023

A new Pull Request was created by @fmanteca (Pedro J. Fernndez Manteca) for CMSSW_13_0_X.

It involves the following packages:

  • L1Trigger/CSCTriggerPrimitives (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @JanFSchulte, @eyigitba, @Martin-Grunewald, @missirol, @ptcox, @valuev this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

backport of #42485

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fce6eb/34233/summary.html
COMMIT: 4da29a9
CMSSW: CMSSW_13_0_X_2023-08-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42548/34233/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 231 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3281270
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3281227
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@fmanteca @aloeliger : isn't a backport to the next data taking release, 13_2_X, also needed?

@fmanteca
Copy link
Contributor Author

Hi @perrotta, the L1 seed for tagging loose muon showers is not included in the HI menu, so in principle a backport to 13_2_X is not needed.

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 48b3bc2 into cms-sw:CMSSW_13_0_X Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants