Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elements_with_stride_nd when the index is outside the extent [13.0.x] #42561

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 14, 2023

PR description:

Extend testKernel.dev.cc with a 2D kernel test that uses large block sizes and redundant blocks.

Fix elements_with_stride_nd when the initial index is outside the extent; this fixes the issue revealed by the new test.

Also:

  • add support for the AccCpuThreads accelerator;
  • rename member variables for consistency;
  • improve comments.

PR validation:

The new unit tests completes successfully.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #42558.

Also:
  - add support for the AccCpuThreads acelerator
  - rename member variables for consistency
  - improve comments
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Aug 14, 2023
@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 14, 2023

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 14, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_0_X.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 14, 2023

backport #42558

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 14, 2023

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 14, 2023

please test with cms-sw/cmsdist#8648

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 14, 2023

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b289c7/34264/summary.html
COMMIT: 938674c
CMSSW: CMSSW_13_0_X_2023-08-13-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42561/34264/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 56 lines to the logs
  • Reco comparison results: 23 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3281270
  • DQMHistoTests: Total failures: 129
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3281119
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 40086
  • DQMHistoTests: Total failures: 199
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39887
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 6 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e5b06f9 into cms-sw:CMSSW_13_0_X Aug 15, 2023
@fwyzard fwyzard deleted the Alpaka_updates_13.0.x branch January 30, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants