Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the GenericConsumer to consume individual products #43338

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 20, 2023

PR description:

Extend the GenericConsumer to support the possibility of consuming the individual products produced by a module.

The new syntax is similar to the "keep" statements in an OutputModule.
The old syntax, specifying only the module label, is still supported.

PR validation:

The new unit tests pass.

PR backport:

May be backported to 13.3.x to support the alpaka migration.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43338/37791

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • FWCore/Modules (core)

@smuzaffar, @makortel, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit, @makortel, @missirol this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 20, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ef328/35968/summary.html
COMMIT: bef578c
CMSSW: CMSSW_14_0_X_2023-11-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43338/35968/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

FWCore/Modules/src/GenericConsumer.cc Outdated Show resolved Hide resolved
FWCore/Modules/src/GenericConsumer.cc Outdated Show resolved Hide resolved
FWCore/Modules/test/testGenericConsumer.py Show resolved Hide resolved
FWCore/Modules/test/testGenericConsumer.py Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43338/37796

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43338 was updated. @makortel, @Dr15Jones, @smuzaffar, @cmsbuild can you please check and sign again.

@makortel
Copy link
Contributor

Workflow 9.0 showed differences in 13 histograms in GlobalHitsV/MCGeant folder. I want to re-run the tests even if this PR can't possibly cause anything there.

Opened an issue #43415

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 27, 2023

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43338/37922

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43338 was updated. @Dr15Jones, @smuzaffar, @makortel can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ef328/36112/summary.html
COMMIT: eec344d
CMSSW: CMSSW_14_0_X_2023-11-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43338/36112/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

The usual #39803 and #43293

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 53708a6 into cms-sw:master Nov 28, 2023
11 checks passed
@fwyzard fwyzard deleted the improve_GenericConsumer branch January 30, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants