-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the GenericConsumer
to consume individual products
#43338
Conversation
c924347
to
bef578c
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43338/37791
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
@smuzaffar, @makortel, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ef328/35968/summary.html Comparison SummarySummary:
|
bef578c
to
b16e989
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43338/37796
|
Pull request #43338 was updated. @makortel, @Dr15Jones, @smuzaffar, @cmsbuild can you please check and sign again. |
b16e989
to
c8a45ce
Compare
Opened an issue #43415 |
ad41df7
to
eec344d
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43338/37922
|
Pull request #43338 was updated. @Dr15Jones, @smuzaffar, @makortel can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5ef328/36112/summary.html Comparison SummarySummary:
|
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Extend the
GenericConsumer
to support the possibility of consuming the individual products produced by a module.The new syntax is similar to the "keep" statements in an
OutputModule
.The old syntax, specifying only the module label, is still supported.
PR validation:
The new unit tests pass.
PR backport:
May be backported to 13.3.x to support the alpaka migration.