fix HLT track collection for SiStrip at HLT monitoring

[mmusich]

PR description:

I casually noticed that in online DQM HLT on-track SiStrip quantities are empty (see e.g. here), while reviewing the TSG ticket CMSHLT-2766.
I think this is due to the fact that in the configuration file an not-existent track collection (hltTracksMerged instead of hltMergedTracks) is passed to the track refitter:

cmssw/DQM/HLTEvF/python/HLTSiStripMonitoring_cff.py

Line 226 in c4e98e9

hltTrackRefitterForSiStripMonitorTrack.src = cms.InputTag("hltTracksMerged") # hltIter2Merged

I fix this here, while also removing where possible redundant cms type specifications

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cms-sw/trk-dpg-l2 FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43385/37879

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• DQM/HLTEvF (dqm, hlt)

@rvenditti, @nothingface0, @mmusich, @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@silviodonato, @missirol, @mtosi this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[mmusich]

type trk

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ad04b/36052/summary.html
COMMIT: ff5b07e
CMSSW: CMSSW_14_0_X_2023-11-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43385/36052/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 55 lines to the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3367918
• DQMHistoTests: Total failures: 1122
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3366774
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

@syuvivida would it be possible for you to test this PR in playback? Thank you

[syuvivida]

Hi @mmusich
here is the playback test with 13_0_10 + this PR. The results are shown in the playback DQMGUI using the streamers of run 370580 as input, DQMGUI.

[mmusich]

The results are shown in the playback using the streamers of run 370580 as input, DQMGUI

Thank you very much @syuvivida.
I see now that the on-track SiStrip plots are filled as expected (see e.g. here), whereas in the production environment they weren't (see e.g. here)

[mmusich]

+hlt

• playback results according to expectations, see fix HLT track collection for SiStrip at HLT monitoring #43385 (comment)
• some spurious differences in wf 9.0 and 12434.7 can be attributed to the standing open issues Spurious comparison differences in workflows 9.0 and 25.0 #43415 and spurious differences in outputs of Run-3 wfs *.7 #39803

[syuvivida]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1