Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run3-gex175 Remove std::cout in favour of edm::LogVerbatim in Fireworks/Geometry #43447

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Run3-gex175 Remove std::cout in favour of edm::LogVerbatim in Fireworks/Geometry #43447

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
434f1a9
Remove std::cout in favour of edm::LogVerbatim in Fireworks/Geometry
Nov 30, 2023
23e9fb8
Code checks
Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Fireworks/Geometry/plugins/TGeoMgrFromDdd.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,8 @@ TGeoMgrFromDdd::ReturnType TGeoMgrFromDdd::produce(const DisplayGeomRecord& iRec
gGeoIdentity = new TGeoIdentity("Identity");
}

std::cout << "about to initialize the DDCompactView walker"
<< " with a root node " << viewH->root() << std::endl;
edm::LogVerbatim("TGeoMgrFromDdd") << "about to initialize the DDCompactView walker with a root node "
<< viewH->root() << std::endl;

auto walker = viewH->walker();
auto info = walker.current();
Expand Down Expand Up @@ -170,10 +170,10 @@ TGeoMgrFromDdd::ReturnType TGeoMgrFromDdd::produce(const DisplayGeomRecord& iRec
auto info = walker.current();

if (m_verbose) {
std::cout << "parentStack of size " << parentStack.size() << std::endl;
edm::LogVerbatim("TGeoMgrFromDdd") << "parentStack of size " << parentStack.size();
auto num = (info.second != nullptr) ? info.second->copyno() : 0;
std::cout << info.first.name() << " " << num << " " << DDSolidShapesName::name(info.first.solid().shape())
<< std::endl;
edm::LogVerbatim("TGeoMgrFromDdd") << info.first.name() << " " << num << " "
<< DDSolidShapesName::name(info.first.solid().shape());
}

std::string name = m_fullname ? info.first.name().fullname() : info.first.name().name();
Expand Down Expand Up @@ -614,7 +614,7 @@ TGeoVolume* TGeoMgrFromDdd::createVolume(const std::string& iName, const DDSolid

TGeoMaterial* TGeoMgrFromDdd::createMaterial(const DDMaterial& iMaterial) {
std::string mat_name = m_fullname ? iMaterial.name().fullname() : iMaterial.name().name();
edm::LogVerbatim("TGeoMgrFromDdd") << "createMateriale with name: " << mat_name;
edm::LogVerbatim("TGeoMgrFromDdd") << "createMaterial with name: " << mat_name;
TGeoMaterial* mat = nameToMaterial_[mat_name];

if (mat == nullptr) {
Expand Down