Phase2-hgx350 Make modifications for the HGCal version V18 in the case of mouse bite, guard rings, ...

[bsunanda]

PR description:

Make modifications for the HGCal version V18 in the case of mouse bite, guard rings, ...

PR validation:

Using the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43449/37998

• This PR adds an extra 36KB to repository

• Found files with invalid states:

  • Geometry/HGCalCommonData/src/#HGCalCellUV.cc#:
    • Added: 742517c
    • Deleted: fc5cb9a

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43449/37998/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43449/37998/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43449/37998/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43449/37998/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43449/37999

• This PR adds an extra 40KB to repository

• Found files with invalid states:

  • Geometry/HGCalCommonData/src/#HGCalCellUV.cc#:
    • Added: 742517c
    • Deleted: fc5cb9a

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)
• SimG4CMS/Calo (simulation)

@cmsbuild, @makortel, @srimanob, @bsunanda, @civanch, @mdhildreth, @Dr15Jones can you please review it and eventually sign? Thanks.
@fabiocos, @wang0jin, @thomreis, @rovere, @felicepantaleo, @ReyerBand, @slomeo this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6dc338/36209/summary.html
COMMIT: f4294f0
CMSSW: CMSSW_14_0_X_2023-11-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43449/36209/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 242 lines from the logs
• Reco comparison results: 20 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 1197
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3368813
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

@cmsbuild please test

Just to re-trigger the test, to see if we can get clean result on unrelated workflows.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6dc338/36234/summary.html
COMMIT: f4294f0
CMSSW: CMSSW_14_0_X_2023-11-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43449/36234/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 290 lines from the logs
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 1180
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3368830
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[srimanob]

Note to @bsunanda @civanch

Not relate to this PR, but please consider to issue reported by static check.

/pool/condor/dir_62157/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-30-2300/src/SimG4CMS/Calo/src/CaloSD.cc:220:13: warning: const_cast was used, this may result in thread-unsafe code [threadsafety.ConstCast]
  220 |             const_cast<G4Track*>(tk)->SetTrackStatus(fStopAndKill);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~
/pool/condor/dir_62157/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-30-2300/src/SimG4CMS/Calo/src/CaloSD.cc:422:102: warning: Called C++ object pointer is null [core.CallAndMessage]
  422 |       edm::LogVerbatim("CaloSim") << "CaloSD: EndofEvent entered for container " << k << " with " << theHC[0]->entries()
      |               

[civanch]

@srimanob , Thanks for pointing to the problem. Here const_cast is thread safe. Geant4 design expect that SD class or SteppingAction cannot change G4Track status, only physics process should do this. In reality, this rule will bring an overhead, because such extra process will need to make extra filtering, so we prefer doing this in user actions, where we check several things. At the same time, your comment is valid, because it is acceptable if SteppingAction may kill a track, why CaloSD is doing this to me not clear. I would think that responsibility for MC truth and to change track status should not be spread between several places - they should be in one place.

[antoniovilela]

+1