Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-HGX350A Resolve the scenario for V18 version of HGCal Geometry #43661

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jan 5, 2024

PR description:

Resolve the scenario for V18 version of HGCal Geometry

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43661/38326

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43661/38327

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/Geometry (upgrade, geometry)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (upgrade, geometry)
  • SimG4CMS/Calo (simulation)

@miquork, @srimanob, @Dr15Jones, @AdrianoDee, @davidlange6, @cmsbuild, @rappoccio, @civanch, @makortel, @bsunanda, @mdhildreth, @antoniovilela, @sunilUIET, @subirsarkar, @fabiocos can you please review it and eventually sign? Thanks.
@VourMa, @mtosi, @felicepantaleo, @sameasy, @wang0jin, @vargasa, @VinInn, @mmusich, @Martin-Grunewald, @makortel, @dgulhan, @missirol, @GiacomoSguazzoni, @rovere, @slomeo, @ReyerBand, @fabiocos, @thomreis, @JanFSchulte this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Jan 5, 2024

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02cede/36714/summary.html
COMMIT: 7082c6d
CMSSW: CMSSW_14_0_X_2024-01-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43661/36714/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 89 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3247277
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3247252
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Jan 5, 2024

test parameters:

  • workflows = 27234.0
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@srimanob
Copy link
Contributor

srimanob commented Jan 5, 2024

@cmsbuild please test

@civanch
Copy link
Contributor

civanch commented Jan 5, 2024

+1

@bsunanda
Copy link
Contributor Author

bsunanda commented Jan 6, 2024

@sunilUIET Could you approve this?

@sunilUIET
Copy link
Contributor

+pdmv

@bsunanda
Copy link
Contributor Author

bsunanda commented Jan 9, 2024

@rappoccio @antoniovilela Please merge this PR

@bsunanda
Copy link
Contributor Author

@rappoccio @antoniovilela Please merge this PR. we are waiting for the next PR

@bsunanda
Copy link
Contributor Author

@rappoccio @antoniovilela Please merge this PR. We are waiting for this new IB to declare a new workflow

1 similar comment
@bsunanda
Copy link
Contributor Author

@rappoccio @antoniovilela Please merge this PR. We are waiting for this new IB to declare a new workflow

@bsunanda
Copy link
Contributor Author

type bug fix

@bsunanda
Copy link
Contributor Author

Please merge - otherwise V18 is meaningless

@bsunanda
Copy link
Contributor Author

Bug fix

@bsunanda
Copy link
Contributor Author

Type Bug-Fix

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 10b8a60 into cms-sw:master Jan 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants