Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Update Run3 CSC conditions in 2022, 2023, 2024 realistic MC GTs and offline data GT #43901

Conversation

saumyaphor4252
Copy link
Contributor

Backport of #43900

PR description:

This PR updates the Run3 CSC conditions in the following GTs:

  • 2022, 2023, 2024 realistic MC GTs
  • Run3 offline data GT for future ReReco
    requested in [1] and [2] respectively. More details and internal validations can be found in [3].

[1] https://cms-talk.web.cern.ch/t/mc-gt-update-csc-conditions-for-run3-mc-gts/33583
[2] https://cms-talk.web.cern.ch/t/full-track-validation-hlt-express-prompt-offline-csc-run3-condition-updates-for-2024-data-taking/33776
[3] https://indico.cern.ch/event/1358549/#9-csc-conditions-update-for-20

For more details and GT differences, see master PR.

PR validation:

See master PR #43900

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Exact backport of #43900

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@tocheng, @fabiocos, @rsreds, @yuanchao, @mmusich, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

cms-bot internal usage

@saumyaphor4252
Copy link
Contributor Author

backport of #43900

@saumyaphor4252
Copy link
Contributor Author

test parameters:

  • workflows = 140.022,140.069,159.1,160.1,312.0,12834.0,12401.0,12404.0,12412.0,12423.0,12425.0,12430.0,12431.0,12444.0,12447.0,12450.0,12504.0,12634.586,12650.0,12737.0
  • relvals_opt = --what upgrade,standard

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2024

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e6c17/37287/summary.html
COMMIT: b790c58
CMSSW: CMSSW_14_0_X_2024-02-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43901/37287/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

ValueError: Undefined workflows: 312.0

----- Begin Fatal Exception 07-Feb-2024 20:12:35 CET-----------------------
An exception of category 'CorrelatedNoisifier' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 5 stream: 0
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module CSCDigiToRawModule/'cscpacker'
   [5] Calling method for module CSCDigiProducer/'simMuonCSCDigis'
Exception Message:
Bad covariance matrix. [      14.5542           0           0           0           0           0           0           0
             0     14.5542           0           0           0           0           0           0
             0           0      13.839      11.933      11.208           0           0           0
             0           0      11.933      13.942       11.93      11.288           0           0
             0           0      11.208       11.93       13.91      11.968      11.331           0
             0           0           0      11.288      11.968      13.985      12.084           0
             0           0           0           0      11.331      12.084      14.062           0
             0           0           0           0           0           0           0     14.5542 ]
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 07-Feb-2024 20:15:24 CET-----------------------
An exception of category 'CorrelatedNoisifier' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 8 stream: 0
   [1] Running path 'dqmofflineOnPAT_1_step'
   [2] Prefetching for module SingleTopTChannelLeptonDQM_miniAOD/'singleTopElectronMediumDQM_miniAOD'
   [3] Prefetching for module PATMuonSlimmer/'slimmedMuons'
   [4] Prefetching for module PATMuonSelector/'selectedPatMuons'
   [5] Prefetching for module PATMuonProducer/'patMuons'
   [6] Prefetching for module MuonProducer/'muons'
   [7] Prefetching for module MuonIdProducer/'muons1stStep'
   [8] Prefetching for module CSCSegmentProducer/'cscSegments'
   [9] Prefetching for module CSCRecHitDProducer/'csc2DRecHits'
   [10] Calling method for module CSCDigiProducer/'simMuonCSCDigis'
Exception Message:
Bad covariance matrix. [      3.18266           0           0           0           0           0           0           0
             0     3.18266           0           0           0           0           0           0
             0           0       0.667       0.333           0           0           0           0
             0           0       0.333       0.222       -0.11       0.111           0           0
             0           0           0       -0.11       0.222       0.111      -0.332           0
             0           0           0       0.111       0.111       0.222           0           0
             0           0           0           0      -0.332           0       0.667           0
             0           0           0           0           0           0           0     3.18266 ]
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 11846.011846.0_ZEE_14+2021PU/step2_ZEE_14+2021PU.log
  • 11846.1911846.19_ZEE_14+2021PU_ecalDeepSC/step2_ZEE_14+2021PU_ecalDeepSC.log
  • 13034.013034.0_TTbar_14TeV+2024PU/step2_TTbar_14TeV+2024PU.log
Expand to see more relval errors ...

AddOn Tests

----- Begin Fatal Exception 07-Feb-2024 19:49:54 CET-----------------------
An exception of category 'CorrelatedNoisifier' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 6 stream: 3
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for module CSCDigiProducer/'simMuonCSCDigis'
Exception Message:
Bad covariance matrix. [      1.60782           0           0           0           0           0           0           0
             0     1.60782           0           0           0           0           0           0
             0           0       0.688       0.188      -0.499           0           0           0
             0           0       0.188       0.188           0       0.313           0           0
             0           0      -0.499           0         0.5      -0.499      -0.499           0
             0           0           0       0.313      -0.499       1.188      -0.249           0
             0           0           0           0      -0.499      -0.249         1.5           0
             0           0           0           0           0           0           0     1.60782 ]
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 07-Feb-2024 19:49:12 CET-----------------------
An exception of category 'CorrelatedNoisifier' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 6 stream: 3
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for module CSCDigiProducer/'simMuonCSCDigis'
Exception Message:
Bad covariance matrix. [      1.60782           0           0           0           0           0           0           0
             0     1.60782           0           0           0           0           0           0
             0           0       0.688       0.188      -0.499           0           0           0
             0           0       0.188       0.188           0       0.313           0           0
             0           0      -0.499           0         0.5      -0.499      -0.499           0
             0           0           0       0.313      -0.499       1.188      -0.249           0
             0           0           0           0      -0.499      -0.249         1.5           0
             0           0           0           0           0           0           0     1.60782 ]
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 07-Feb-2024 19:50:06 CET-----------------------
An exception of category 'CorrelatedNoisifier' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 6 stream: 3
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Prefetching for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
   [7] Calling method for module CSCDigiProducer/'simMuonCSCDigis'
Exception Message:
Bad covariance matrix. [      1.60782           0           0           0           0           0           0           0
             0     1.60782           0           0           0           0           0           0
             0           0       0.688       0.188      -0.499           0           0           0
             0           0       0.188       0.188           0       0.313           0           0
             0           0      -0.499           0         0.5      -0.499      -0.499           0
             0           0           0       0.313      -0.499       1.188      -0.249           0
             0           0           0           0      -0.499      -0.249         1.5           0
             0           0           0           0           0           0           0     1.60782 ]
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@cmsbuild
Copy link
Contributor

Pull request #43901 was updated. @saumyaphor4252, @consuegs, @cmsbuild, @perrotta can you please check and sign again.

@saumyaphor4252
Copy link
Contributor Author

test parameters:

  • workflows = 140.022,140.069,159.1,160.1,312.0,12834.0,12401.0,12404.0,12412.0,12423.0,12425.0,12430.0,12431.0,12444.0,12447.0,12450.0,12504.0,12634.586,12650.0,12737.0
  • relvals_opt = --what upgrade,standard,pileup

@saumyaphor4252
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e6c17/37427/summary.html
COMMIT: 641e6db
CMSSW: CMSSW_14_0_X_2024-02-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43901/37427/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 9921 differences found in the comparisons
  • DQMHistoTests: Total files compared: 67
  • DQMHistoTests: Total histograms compared: 5846987
  • DQMHistoTests: Total failures: 23345
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 5823619
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.016 KiB( 66 files compared)
  • DQMHistoSizes: changed ( 140.069 ): -0.016 KiB JetMET/SUSYDQM
  • Checked 288 log files, 252 edm output root files, 67 DQM output files
  • TriggerResults: found differences in 9 / 65 workflows

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8e35ba9 into cms-sw:CMSSW_14_0_X Feb 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants