Add support to multi layout portable collections (up to 5) [14.0.x] #43946
Conversation
The design is recursive, but ROOT seems not to serialize variadic templates, so we have a
5 elements design. This number is arbitrary and can be changed with relatively little work.
The order of the PortableDeviceCollection template parameters is changed from device at the end
to device at the begining to accomodate the pseudo variadic templation.
A test validates the colleciton with two layouts and three layouts.
The layout and view can be accessed by index or type, on the condition the type is present only
once in the collection.
The default index is set to 0 to minimize the need for chages in the single layout case. Empty
template parameters square bracket ("<>") are needed in some cases.
Convenience scripts are added to generate the XML need for dictionary generation but has to be edited
if there are commonalities between multiple collections.
|
please test |
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_14_0_X. It involves the following packages:
@makortel, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
cms-bot internal usage |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test test-das-selected-lumis had ERRORS Comparison SummarySummary:
|
The failed test is unrelated to this PR:
|
|
ignore tests-rejected with external-failure we have randomly seen such failure but really do not understand why |
|
+heterogeneous |
cmsbuild
added
fully-signed
heterogeneous-approved
and removed
pending-signatures
heterogeneous-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (test failures were overridden) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
urgent for CMSSW_14_0_0, as discussed at the ORP on 2024/02/13 |
|
+1 |
PR description:
The design is recursive, but ROOT seems not to serialize variadic templates, so we have a 5 elements design. This number is arbitrary and can be changed with relatively little work.
The order of the PortableDeviceCollection template parameters is changed from device at the end to device at the beginning to accommodate the pseudo variadic templation.
A test validates the collection with two layouts and three layouts.
The layout and view can be accessed by index or type, on the condition the type is present only once in the collection.
The default index is set to 0 to minimize the need for changes in the single layout case. Empty template parameters square bracket ("<>") are needed in some cases.
Convenience scripts are added to generate the XML need for dictionary generation but has to be edited if there are commonalities between multiple collections.
PR validation:
The PR is validated with the pre-existing
HeterogeneousCore/AlpakaTest/test/testHeterogeneousCoreAlpakaTestWriteRead.shwhich has been extended to add a two-layouts example.Backport status
Backport of #40285 to CMSSW 14.0.x, from the same branch.