Fix globToRegex and put it in anonymous namespace

[iarspider]

PR description:

Follow-up on comments in #43334

PR validation:

Bot tests

[iarspider]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43967/38870

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43967/38870/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43967/38870/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[iarspider]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43967/38873

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Validation/RecoTau (dqm)

@tjavaid, @antoniovagnerini, @nothingface0, @rvenditti, @syuvivida can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-418761/37469/summary.html
COMMIT: 3072d4e
CMSSW: CMSSW_14_1_X_2024-02-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43967/37469/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @saumyaphor4252 Update Run3 CSC conditions in 2022, 2023, 2024 realistic MC GTs and offline data GT #43900
• @mbluj Configuration arguments for version and packing schema of covariance in DeepJetTag producer #43917
• @jsamudio Introduce matrix workflows for Alpaka-based Particle Flow #43701
• @CTPPS CTPPS update HLTPPSJetComparisonFilter to use LHCInfoCombined #43951

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-418761/37469/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-418761/37469/git-merge-result

Comparison Summary

Summary:

• You potentially removed 89 lines from the logs
• Reco comparison results: 3966 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248554
• DQMHistoTests: Total failures: 7963
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3240569
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: found differences in 3 / 46 workflows

[smuzaffar]

please test

[smuzaffar]

@iarspider , please open a backport of this for 14.0.X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-418761/37475/summary.html
COMMIT: 3072d4e
CMSSW: CMSSW_14_1_X_2024-02-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43967/37475/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 75 lines from the logs
• Reco comparison results: 49 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248554
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3248523
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

type bug-fix

[smuzaffar]

@cms-sw/dqm-l2 can you please review it.

[iarspider]

@iarspider , please open a backport of this for 14.0.X

The original PR was not in 14_0_X, should I backport it as well?

[tjavaid]

@cms-sw/dqm-l2 can you please review it.

Alright, I'll be able to get a bit later today.

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1