Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Fix HLT customization for alpaka PF #44000

Conversation

waredjeb
Copy link
Contributor

@waredjeb waredjeb commented Feb 16, 2024

This PR is a backport of #43999

This PR fixes the customization of Alpaka-PF introduced with #43979 with moving the CPU serial module to DQM_HcalReconstruction_v6

GPU vs CPU comparison at DQMOnline will follow up, currently we are only saving the needed collections

Validated running:

https_proxy=http://cmsproxy.cms:3128/ hltGetConfiguration /dev/CMSSW_14_0_0/GRun --unprescale --output all --globaltag auto:phase1_2024_realistic --mc --max-events 10 --input /store/mc/Run3Winter24Digi/TT_TuneCP5_13p6TeV_powheg-pythia8/GEN-SIM-RAW/133X_mcRun3_2024_realistic_v8-v2/80000/dc984f7f-2e54-48c4-8950-5daa848b6db9.root --customise HLTrigger/Configuration/customizeHLTforAlpaka.customizeHLTforAlpaka > hlt.py 

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2024

A new Pull Request was created by @waredjeb for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor

fwyzard commented Feb 16, 2024

type bugfix

@fwyzard
Copy link
Contributor

fwyzard commented Feb 16, 2024

backport #43999

@fwyzard
Copy link
Contributor

fwyzard commented Feb 16, 2024

please test

@waredjeb waredjeb force-pushed the fix_integratePFAlpakaClusteringAtHLT_14_0_0_pre3 branch from 0418195 to 0a56692 Compare February 16, 2024 16:38
@cmsbuild
Copy link
Contributor

Pull request #44000 was updated. @cmsbuild, @mmusich, @Martin-Grunewald can you please check and sign again.

@fwyzard
Copy link
Contributor

fwyzard commented Feb 16, 2024

please test

@fwyzard
Copy link
Contributor

fwyzard commented Feb 16, 2024

@waredjeb can you expand the description of this PR ?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e610a/37531/summary.html
COMMIT: 0a56692
CMSSW: CMSSW_14_0_X_2024-02-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44000/37531/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@Martin-Grunewald
Copy link
Contributor

+1

@mmusich
Copy link
Contributor

mmusich commented Feb 21, 2024

type pf

@cmsbuild cmsbuild added the pf label Feb 21, 2024
@cmsbuild
Copy link
Contributor

Pull request #44000 was updated. @cmsbuild, @mmusich, @Martin-Grunewald can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Feb 21, 2024

enable gpu

@mmusich
Copy link
Contributor

mmusich commented Feb 21, 2024

test parameters:

  • workflow_opts_gpu= -w upgrade
  • workflows_gpu = 12434.402, 12434.403, 12434.404, 12434.412

@mmusich
Copy link
Contributor

mmusich commented Feb 21, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e610a/37610/summary.html
COMMIT: e6e2d97
CMSSW: CMSSW_14_0_X_2024-02-21-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44000/37610/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 6
  • DQMHistoTests: Total histograms compared: 74321
  • DQMHistoTests: Total failures: 369
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 73952
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 5 files compared)
  • Checked 23 log files, 27 edm output root files, 6 DQM output files
  • TriggerResults: found differences in 3 / 5 workflows

@Martin-Grunewald
Copy link
Contributor

+1

@mmusich
Copy link
Contributor

mmusich commented Feb 22, 2024

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7e61dec into cms-sw:CMSSW_14_0_X Feb 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants