Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Simplify definition of PortableMultiCollection<TDev, ...>, and allow it to be used outside of ALPAKA_ACCELERATOR_NAMESPACE #44014

Merged

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Feb 19, 2024

PR description:

Backport of #43983. Description of the original PR:

I.e. repeat #43310 on PortableMultiCollection (that was added in #40285).

PR validation:

None beyond the tests of #43983

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #43983

… it to be used outside of ALPAKA_ACCELERATOR_NAMESPACE

I.e. repeat cms-sw#43310 on PortableMultiCollection.
@makortel makortel changed the title Simplify definition of PortableMultiCollection<TDev, ...>, and allow it to be used outside of ALPAKA_ACCELERATOR_NAMESPACE [14_0_X] Simplify definition of PortableMultiCollection<TDev, ...>, and allow it to be used outside of ALPAKA_ACCELERATOR_NAMESPACE Feb 19, 2024
@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Feb 19, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 19, 2024

A new Pull Request was created by @makortel for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/Portable (heterogeneous)

@fwyzard, @cmsbuild, @makortel can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 19, 2024

cms-bot internal usage

@makortel
Copy link
Contributor Author

enable gpu

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf0d68/37555/summary.html
COMMIT: 86e706b
CMSSW: CMSSW_14_0_X_2024-02-19-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44014/37555/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 59 lines to the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248626
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248601
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 501
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39239
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@makortel
Copy link
Contributor Author

@antoniovilela
Copy link
Contributor

backport of #43983

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e0dba32 into cms-sw:CMSSW_14_0_X Feb 21, 2024
13 checks passed
@makortel makortel deleted the simplifyPortableMultiCollection_140x branch February 21, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants