[PPS] Added gtStage2DigisAlCaRecoProducer to ALCARECOPRODUCER #44044

grzanka · 2024-02-21T16:00:26Z

PR description:

The PR adds the hltGtStage2Digis production step in the PPS ALCARECO sequence and preserves this product in the output. This change follows the discussion in CMSHLT-2989, in which the the hltFEDSelectorL1 products are added to the HLT output in order to have access to the prescale values in the final dataset.

A backport to CMSSW_14_0_X will be created as soon as this PR is fully checked out.

PR validation:

The PR was tested using privately-produced input files (check recipe below) and unit tests run locally. These input files (one for the express stream and one for the prompt) are available as:

/afs/cern.ch/user/a/abellora/public/ALCAPPSTest/outputALCAPPSExpress.root
/afs/cern.ch/user/a/abellora/public/ALCAPPSTest/outputALCAPPSPrompt.root
The tests were executed with:

cmsDriver.py testExpressPPSAlCaRecoProducer -s ALCAPRODUCER:PPSCalMaxTracks,ENDJOB --process ALCARECO --scenario pp --era run3_common --conditions auto:run3_data_express --data --datatier ALCARECO --eventcontent ALCARECO --nThreads 8 --number 100 --filein ${INPUTFILE} --fileout file:outputALCAPPS_RECO_express.root --customise_commands="$customise_commands"
and

cmsDriver.py testPromptPPSAlCaRecoProducer -s ALCAPRODUCER:PPSCalMaxTracks,ENDJOB --process ALCARECO --scenario pp --era run3_common --conditions auto:run3_data_express --data --datatier ALCARECO --eventcontent ALCARECO --nThreads 8 --number 100 --filein ${INPUTFILE} --fileout file:outputALCAPPS_RECO_prompt.root --customise_commands="$customise_commands"
where ${INPUTFILE} is the respective file above and $customise_commands is taken from the express test-script or prompt test-script, respectively.

These input files should be moved to the /store/group/alca_global/pps_alcareco_producer_tests area and become the new test files.

Backward compatibility

The hltGtStage2Digis expects a product (under hltFEDSelectorL1 label) which is not present in 2023 (but will be available in 2024 data) and older datasets.
We have a couple of PPS relvals (1043,1044,1045) using PPS ALCARECO producer on 2022 raw data, see PPS ALCARECO relvals.
These relvals should be used in testing of this PR, as we believe they are not part of usual set of runTheMatrix tests.

When we tested this PR we discovered that these relvals (1043,1044,1045) were succeeding, but the step2 log files contained an expected error message (as the product was not found in 2022 raw data):

%MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis 20-Feb-2024 16:24:34 CET  Run: 355207 Event: 748612
Cannot unpack: no FEDRawDataCollection found

We are open for discussion on proper back-ward compatibility mode.

HLT test file production recipe

HLT test files were produced for a ZeroBias RAW file from run 367104.

CMSSW_13_0_5_patch1 was used (same version used at P5 for that run)
An HLT config was created with the same GT and menu used for data-taking using: hltGetConfiguration adg:/cdaq/physics/Run2023/2e34/v1.0.2/HLT/V6 --data --output all --max-events 1000 --globaltag 130X_dataRun3_HLT_v2 --eras Run3 --input /store/data/Run2023C/ZeroBias/RAW/v1/000/367/104/00000/ca4253b3-9a09-4158-8036-501272d6fe16.root
The config was modified in order to implement the same changes of CMSHLT-2989 by modifying the outputCommands of the hltOutputALCAPPSExpress and hltOutputALCAPPSPrompt modules.

cmsbuild · 2024-02-21T16:00:53Z

cms-bot internal usage

cmsbuild · 2024-02-21T16:08:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44044/38985

This PR adds an extra 16KB to repository

cmsbuild · 2024-02-21T16:08:30Z

A new Pull Request was created by @grzanka for master.

It involves the following packages:

Calibration/PPSAlCaRecoProducer (alca)

@cmsbuild, @consuegs, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks.
@rsreds, @mmusich, @tocheng, @yuanchao this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

saumyaphor4252 · 2024-02-21T17:15:10Z

@cmsbuild please test

mmusich · 2024-02-21T17:19:58Z

When we tested this PR we discovered that these relvals (1043,1044,1045) were succeeding,

Shouldn't these workflows be included in the tests?

saumyaphor4252 · 2024-02-21T17:22:14Z

@cmsbuild please abort

saumyaphor4252 · 2024-02-21T17:31:12Z

test parameters:

workflows = 1043.0,1044.0,1045.0

saumyaphor4252 · 2024-02-21T17:33:07Z

@cmsbuild please test

missirol · 2024-02-21T18:57:18Z

Calibration/PPSAlCaRecoProducer/python/ALCARECOPPSCalMaxTracks_cff.py


 ctppsDiamondRawToDigiAlCaRecoProducer  = _ctppsDiamondRawToDigi.clone(rawDataTag = 'hltPPSCalibrationRaw')
 totemTimingRawToDigiAlCaRecoProducer = _totemTimingRawToDigi.clone(rawDataTag = 'hltPPSCalibrationRaw')
 ctppsPixelDigisAlCaRecoProducer = _ctppsPixelDigis.clone(inputLabel = 'hltPPSCalibrationRaw')
+hltGtStage2Digis = _gtStage2Digis.clone(InputLabel="hltFEDSelectorL1")


Mh.. the way I understand it, we try [*] to 'reserve' the name hlt* for products that come directly from the HLT process, so here I would suggest to use a different name for hltGtStage2Digis. Tagging @Martin-Grunewald.

[*] I think we do use hlt* modules in some offline workflows related to RawPrime, but that's maybe a special case.

I agree with @missirol please change the label to avoid hlt - maybe alcaGtStage2Digis - and propagate.

maybe alcaGtStage2Digis - and propagate.

I'd just call them gtStage2Digis as everywhere else in offline.

I could change the code to :

from EventFilter.L1TRawToDigi.gtStage2Digis_cfi import gtStage2Digis as _gtStage2Digis (...) gtStage2Digis = _gtStage2Digis.clone(InputLabel="hltFEDSelectorL1")

but wouldn't that introduce some clash ?

With other items I was adding AlCaRecoProducer suffix, like:

from EventFilter.CTPPSRawToDigi.ctppsRawToDigi_cff import ctppsPixelDigis as _ctppsPixelDigis (...) ctppsPixelDigisAlCaRecoProducer = _ctppsPixelDigis.clone(inputLabel = 'hltPPSCalibrationRaw')

Whout do you think then of using:

from EventFilter.L1TRawToDigi.gtStage2Digis_cfi import gtStage2Digis as _gtStage2Digis (...) gtStage2DigisAlCaRecoProducer = _gtStage2Digis.clone(InputLabel="hltFEDSelectorL1")

?

Whout do you think then of using

Seems unnecessarily complicated to me, there are no other producers of this collection on that kind of input data, I am not sure what clashes it could cause.

maybe alcaGtStage2Digis - and propagate.

I'd just call them gtStage2Digis as everywhere else in offline.

After modification in my local CMSSW workspace on lxplus I get following error:

[grzankal@lxplus990 src]$ git diff diff --git a/Calibration/PPSAlCaRecoProducer/python/ALCARECOPPSCalMaxTracks_cff.py b/Calibration/PPSAlCaRecoProducer/python/ALCARECOPPSCalMaxTracks_cff.py index 1349baa295f..b68c5409f2f 100644 --- a/Calibration/PPSAlCaRecoProducer/python/ALCARECOPPSCalMaxTracks_cff.py +++ b/Calibration/PPSAlCaRecoProducer/python/ALCARECOPPSCalMaxTracks_cff.py @@ -18,13 +18,13 @@ from EventFilter.L1TRawToDigi.gtStage2Digis_cfi import gtStage2Digis as _gtStage ctppsDiamondRawToDigiAlCaRecoProducer = _ctppsDiamondRawToDigi.clone(rawDataTag = 'hltPPSCalibrationRaw') totemTimingRawToDigiAlCaRecoProducer = _totemTimingRawToDigi.clone(rawDataTag = 'hltPPSCalibrationRaw') ctppsPixelDigisAlCaRecoProducer = _ctppsPixelDigis.clone(inputLabel = 'hltPPSCalibrationRaw') -hltGtStage2Digis = _gtStage2Digis.clone(InputLabel="hltFEDSelectorL1") +gtStage2Digis = _gtStage2Digis.clone(InputLabel="hltFEDSelectorL1") ctppsRawToDigiTaskAlCaRecoProducer = cms.Task( ctppsDiamondRawToDigiAlCaRecoProducer, totemTimingRawToDigiAlCaRecoProducer, ctppsPixelDigisAlCaRecoProducer, - hltGtStage2Digis + gtStage2Digis ) ALCARECOPPSCalMaxTracksRaw2Digi = cms.Sequence(ctppsRawToDigiTaskAlCaRecoProducer) @@ -105,4 +105,4 @@ recoPPSSequenceAlCaRecoProducer = cms.Sequence(recoPPSTaskAlCaRecoProducer) # 6. master sequence object #------------------------------------------------------ -seqALCARECOPPSCalMaxTracksReco = cms.Sequence( ALCARECOPPSCalMaxTracksFilter + ALCARECOPPSCalMaxTracksRaw2Digi + recoPPSSequenceAlCaRecoProducer) \ No newline at end of file +seqALCARECOPPSCalMaxTracksReco = cms.Sequence( ALCARECOPPSCalMaxTracksFilter + ALCARECOPPSCalMaxTracksRaw2Digi + recoPPSSequenceAlCaRecoProducer) [grzankal@lxplus990 src]$ cat 1044.0_RunRawPPS2022B/step2_RunRawPPS2022B.log RAW2DIGI,L1Reco,ALCAPRODUCER:PPSCalMaxTracks,ENDJOB entry filelist:step1_dasquery.log found files: ['/store/data/Run2022B/AlCaPPS/RAW/v1/000/355/207/00000/c23440f4-49c0-44aa-b8f6-f40598fb4705.root'] Step: RAW2DIGI Spec: Step: L1Reco Spec: Step: ALCAPRODUCER Spec: ['PPSCalMaxTracks'] Traceback (most recent call last): File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/bin/el9_amd64_gcc12/cmsDriver.py", line 40, in <module> run() File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/bin/el9_amd64_gcc12/cmsDriver.py", line 16, in run configBuilder.prepare() File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/Configuration/Applications/python/ConfigBuilder.py", line 2310, in prepare self.addStandardSequences() File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/Configuration/Applications/python/ConfigBuilder.py", line 850, in addStandardSequences getattr(self,"prepare_"+stepName)(stepSpec = '+'.join(stepSpec)) File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/Configuration/Applications/python/ConfigBuilder.py", line 1336, in prepare_ALCAPRODUCER self.prepare_ALCA(stepSpec, workflow = "producers") File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/Configuration/Applications/python/ConfigBuilder.py", line 1343, in prepare_ALCA alcaConfig,sequence,_=self.loadDefaultOrSpecifiedCFF(stepSpec,self.ALCADefaultCFF) File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/Configuration/Applications/python/ConfigBuilder.py", line 1299, in loadDefaultOrSpecifiedCFF l=self.loadAndRemember(_cff) File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/Configuration/Applications/python/ConfigBuilder.py", line 376, in loadAndRemember self.process.load(includeFile) File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/FWCore/ParameterSet/python/Config.py", line 762, in load self.extend(sys.modules[moduleName]) File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/FWCore/ParameterSet/python/Config.py", line 785, in extend self.__setattr__(name,item) File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/FWCore/ParameterSet/python/Config.py", line 495, in __setattr__ raise ValueError(msg1+s.label_()+msg2) ValueError: Trying to override definition of gtStage2Digis while it is used by the task L1TRawToDigiTask new object defined in: /afs/cern.ch/user/g/grzankal/CMSSW_14_1_0_pre0/src/Calibration/PPSAlCaRecoProducer/python/ALCARECOPPSCalMaxTracks_cff.py existing object defined in: /cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/EventFilter/L1TRawToDigi/python/gtStage2Digis_cfi.py [grzankal@lxplus990 src]$

After modification in my local CMSSW workspace on lxplus I get following error:

You should not clone it, but define it directly anyway no strong push (at least from me).

After modification in my local CMSSW workspace on lxplus I get following error:

You should not clone it, but define it directly anyway no strong push (at least from me).

Naively defining it directly I also get a clash:

[grzankal@lxplus990 src]$ git diff diff --git a/Calibration/PPSAlCaRecoProducer/python/ALCARECOPPSCalMaxTracks_cff.py b/Calibration/PPSAlCaRecoProducer/python/ALCARECOPPSCalMaxTracks_cff.py index 1349baa295f..e9b0bc3e1fd 100644 --- a/Calibration/PPSAlCaRecoProducer/python/ALCARECOPPSCalMaxTracks_cff.py +++ b/Calibration/PPSAlCaRecoProducer/python/ALCARECOPPSCalMaxTracks_cff.py @@ -13,18 +13,25 @@ from EventFilter.CTPPSRawToDigi.ctppsRawToDigi_cff import * from EventFilter.CTPPSRawToDigi.ctppsRawToDigi_cff import ctppsDiamondRawToDigi as _ctppsDiamondRawToDigi from EventFilter.CTPPSRawToDigi.ctppsRawToDigi_cff import totemTimingRawToDigi as _totemTimingRawToDigi from EventFilter.CTPPSRawToDigi.ctppsRawToDigi_cff import ctppsPixelDigis as _ctppsPixelDigis -from EventFilter.L1TRawToDigi.gtStage2Digis_cfi import gtStage2Digis as _gtStage2Digis +#from EventFilter.L1TRawToDigi.gtStage2Digis_cfi import gtStage2Digis as _gtStage2Digis ctppsDiamondRawToDigiAlCaRecoProducer = _ctppsDiamondRawToDigi.clone(rawDataTag = 'hltPPSCalibrationRaw') totemTimingRawToDigiAlCaRecoProducer = _totemTimingRawToDigi.clone(rawDataTag = 'hltPPSCalibrationRaw') ctppsPixelDigisAlCaRecoProducer = _ctppsPixelDigis.clone(inputLabel = 'hltPPSCalibrationRaw') -hltGtStage2Digis = _gtStage2Digis.clone(InputLabel="hltFEDSelectorL1") +#gtStage2Digis = _gtStage2Digis.clone(InputLabel="hltFEDSelectorL1") + +gtStage2Digis = cms.EDProducer( + "L1TRawToDigi", + InputLabel = cms.InputTag("hltFEDSelectorL1"), + Setup = cms.string("stage2::GTSetup"), + FedIds = cms.vint32( 1404 ), +) ctppsRawToDigiTaskAlCaRecoProducer = cms.Task( ctppsDiamondRawToDigiAlCaRecoProducer, totemTimingRawToDigiAlCaRecoProducer, ctppsPixelDigisAlCaRecoProducer, - hltGtStage2Digis + gtStage2Digis ) ALCARECOPPSCalMaxTracksRaw2Digi = cms.Sequence(ctppsRawToDigiTaskAlCaRecoProducer) @@ -105,4 +112,4 @@ recoPPSSequenceAlCaRecoProducer = cms.Sequence(recoPPSTaskAlCaRecoProducer) # 6. master sequence object #------------------------------------------------------ -seqALCARECOPPSCalMaxTracksReco = cms.Sequence( ALCARECOPPSCalMaxTracksFilter + ALCARECOPPSCalMaxTracksRaw2Digi + recoPPSSequenceAlCaRecoProducer) \ No newline at end of file +seqALCARECOPPSCalMaxTracksReco = cms.Sequence( ALCARECOPPSCalMaxTracksFilter + ALCARECOPPSCalMaxTracksRaw2Digi + recoPPSSequenceAlCaRecoProducer) [grzankal@lxplus990 src]$ cat 1044.0_RunRawPPS2022B/step2_RunRawPPS2022B.log RAW2DIGI,L1Reco,ALCAPRODUCER:PPSCalMaxTracks,ENDJOB entry filelist:step1_dasquery.log found files: ['/store/data/Run2022B/AlCaPPS/RAW/v1/000/355/207/00000/c23440f4-49c0-44aa-b8f6-f40598fb4705.root'] Step: RAW2DIGI Spec: Step: L1Reco Spec: Step: ALCAPRODUCER Spec: ['PPSCalMaxTracks'] Traceback (most recent call last): File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/bin/el9_amd64_gcc12/cmsDriver.py", line 40, in <module> run() File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/bin/el9_amd64_gcc12/cmsDriver.py", line 16, in run configBuilder.prepare() File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/Configuration/Applications/python/ConfigBuilder.py", line 2310, in prepare self.addStandardSequences() File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/Configuration/Applications/python/ConfigBuilder.py", line 850, in addStandardSequences getattr(self,"prepare_"+stepName)(stepSpec = '+'.join(stepSpec)) File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/Configuration/Applications/python/ConfigBuilder.py", line 1336, in prepare_ALCAPRODUCER self.prepare_ALCA(stepSpec, workflow = "producers") File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/Configuration/Applications/python/ConfigBuilder.py", line 1343, in prepare_ALCA alcaConfig,sequence,_=self.loadDefaultOrSpecifiedCFF(stepSpec,self.ALCADefaultCFF) File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/Configuration/Applications/python/ConfigBuilder.py", line 1299, in loadDefaultOrSpecifiedCFF l=self.loadAndRemember(_cff) File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/Configuration/Applications/python/ConfigBuilder.py", line 376, in loadAndRemember self.process.load(includeFile) File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/FWCore/ParameterSet/python/Config.py", line 762, in load self.extend(sys.modules[moduleName]) File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/FWCore/ParameterSet/python/Config.py", line 785, in extend self.__setattr__(name,item) File "/cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/FWCore/ParameterSet/python/Config.py", line 495, in __setattr__ raise ValueError(msg1+s.label_()+msg2) ValueError: Trying to override definition of gtStage2Digis while it is used by the task L1TRawToDigiTask new object defined in: /afs/cern.ch/user/g/grzankal/CMSSW_14_1_0_pre0/src/Calibration/PPSAlCaRecoProducer/python/ALCARECOPPSCalMaxTracks_cff.py existing object defined in: /cvmfs/cms.cern.ch/el9_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre0/src/EventFilter/L1TRawToDigi/python/gtStage2Digis_cfi.py

Naively defining it directly I also get a clash

Ok, it is because the relval runs the RAW2DIGI together with ALCA in the same step. One could argue that only a specific raw2digi flavour is actually needed (you don't need to unpack all the FEDs in this scenario), but OK, making it cleaner involves more involved changes. Feel free to call it as you prefer after cloning.

I've renamed hltGtStage2Digis to gtStage2DigisAlCaRecoProducer in 671fafa

cmsbuild · 2024-02-21T20:19:00Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbcd41/37607/summary.html
COMMIT: e15c1e3
CMSSW: CMSSW_14_1_X_2024-02-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44044/37607/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 3119 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 68 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3249495
DQMHistoTests: Total failures: 1192
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3248281
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 164 edm output root files, 51 DQM output files
TriggerResults: no differences found

grzanka · 2024-02-21T20:31:17Z

It seems that checks have passed. As expected we see following messages in the logfile of PPS 1044 relval:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_14_1_X_2024-02-21-1100+dbcd41/61250/validateJR/logRootQA-events.log

Is that tolerable ? Similar message will be printed if this PR is merged and we would re-reco 2023 (or older) data with ALCAPPSRECO producer enabled.

0 Lines only in /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/CMSSW_14_1_X_2024-02-21-1100/1043.0_RunRawPPS2022B/step2_RunRawPPS2022B.log
1001 Lines only in /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dbcd41/1043.0_RunRawPPS2022B/step2_RunRawPPS2022B.log
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 254803
   Cannot unpack: no FEDRawDataCollection found
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 748612
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 994926
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 296924
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 673942
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 391792
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 789278
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 791584
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 894364
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 1007813
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 248452
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 524016
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 774121
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 1042523
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 1045861
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 114611
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 551226
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 552309
   %MSG-e L1T:  L1TRawToDigi:hltGtStage2Digis DATETIME CET  Run: 355207 Event: 784492

grzanka · 2024-02-21T20:34:41Z

Also - to improve testing of this PR we may use the files mentioned in the PR description (/afs/cern.ch/user/a/abellora/public/ALCAPPSTest/outputALCAPPSExpress.root and /afs/cern.ch/user/a/abellora/public/ALCAPPSTest/outputALCAPPSPrompt.root), but they would need to be copied to area accessible by Jenkins

mmusich · 2024-02-21T21:16:45Z

It seems that checks have passed. As expected we see following messages in the logfile of PPS 1044 relval ... Is that tolerable ?

Polluting the logs is in general frowned upon.
It would be nice to gate the execution of the L1T FED unpacker through an era modifier. Unfortunately we don't have a 2024 specific modifier chain, see also discussion at #43761 and related issue #43756.
I am speculating one could put a filter on the presence of the input collection upstream of the unpacker, though I can't say if such a filter already exists in cmssw nor if there is a better (more economical) solution.

grzanka · 2024-02-21T21:22:27Z

It seems that checks have passed. As expected we see following messages in the logfile of PPS 1044 relval ... Is that tolerable ?

Polluting the logs is in general frowned upon. It would be nice to gate the execution of the L1T FED unpacker through an era modifier. Unfortunately we don't have a 2024 specific modifier chain, see also discussion at #43761 and related issue #43756. I am speculating one could put a filter on the presence of the input collection upstream of the unpacker, though I can't say if such a filter already exists in cmssw nor if there is a better (more economical) solution.

We are open to implement any reasonable switch.

As for the time being I will adjust the naming as suggested above.

I can also add some tests for new data scenario, but for that purpose I'd need to get some files copied into /store/group/alca_global/pps_alcareco_producer_tests , but I am afraid I have no rights to write there.

mmusich · 2024-02-26T19:44:47Z

type ctpps

cmsbuild · 2024-02-26T23:58:04Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbcd41/37701/summary.html
COMMIT: 6e62922
CMSSW: CMSSW_14_1_X_2024-02-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44044/37701/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 28 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 2709 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3246471
DQMHistoTests: Total failures: 3306
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3243143
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 164 edm output root files, 51 DQM output files
TriggerResults: no differences found

perrotta · 2024-02-27T08:26:11Z

+alca

Issue Add 2024 PPS relvals able to test the PPSAlCaRecoProcuder on new data (and remove obsolete relvals) #44095 has been opened to remind that the PPS relvals 1043-45will have to be replaced by some updated ones in the matrix as soon as the first 2024 data samples will get available

grzanka · 2024-03-01T16:14:08Z

It seems that this PR passed the test and got first signatures. Is there anything else we need to do to get it merged ?
@mmusich

mmusich · 2024-03-01T16:16:30Z

@grzanka

It seems that this PR passed the test and got first signatures. Is there anything else we need to do to get it merged ?

it doesn't depend on me :D

Allow me to ping @cms-sw/pdmv-l2 and @cms-sw/upgrade-l2 (the update in their signature area is marginal, I don't foresee issues).

subirsarkar · 2024-03-01T18:05:38Z

+Upgrade

saumyaphor4252 · 2024-03-04T11:07:20Z

@cms-sw/pdmv-l2 Ping

AdrianoDee · 2024-03-04T12:10:44Z

+pdmv

cmsbuild · 2024-03-04T12:11:04Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-03-04T13:39:42Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone Feb 21, 2024

cmsbuild added alca-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 21, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 21, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 21, 2024

cmsbuild added tests-pending and removed tests-started labels Feb 21, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 21, 2024

missirol reviewed Feb 21, 2024

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Feb 21, 2024

cmsbuild added the tests-started label Feb 26, 2024

cmsbuild added the ctpps label Feb 26, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 26, 2024

perrotta mentioned this pull request Feb 27, 2024

Add 2024 PPS relvals able to test the PPSAlCaRecoProcuder on new data (and remove obsolete relvals) #44095

Open

cmsbuild added alca-approved and removed alca-pending labels Feb 27, 2024

This was referenced Feb 27, 2024

Add missing newlines under Calibration/PPSAlCaRecoProducer #44117

Closed

Add missing newlines in Calibration modules #44225

Merged

Remove deprecated heavy-ion reconstruction #43824

Merged

cmsbuild added upgrade-approved and removed upgrade-pending labels Mar 1, 2024

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Mar 4, 2024

cmsbuild added orp-approved and removed orp-pending labels Mar 4, 2024

cmsbuild merged commit 927f3ed into cms-sw:master Mar 4, 2024
12 checks passed

cmsbuild mentioned this pull request Mar 9, 2024

Update to CUDA 12.4.0 cms-sw/cmsdist#9046

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PPS] Added gtStage2DigisAlCaRecoProducer to ALCARECOPRODUCER #44044

[PPS] Added gtStage2DigisAlCaRecoProducer to ALCARECOPRODUCER #44044

grzanka commented Feb 21, 2024

cmsbuild commented Feb 21, 2024 •

edited

Loading

cmsbuild commented Feb 21, 2024

cmsbuild commented Feb 21, 2024

saumyaphor4252 commented Feb 21, 2024

mmusich commented Feb 21, 2024

saumyaphor4252 commented Feb 21, 2024

saumyaphor4252 commented Feb 21, 2024 •

edited

Loading

saumyaphor4252 commented Feb 21, 2024

missirol Feb 21, 2024 •

edited

Loading

Martin-Grunewald Feb 21, 2024

mmusich Feb 21, 2024

grzanka Feb 21, 2024

mmusich Feb 21, 2024

grzanka Feb 21, 2024

mmusich Feb 21, 2024

grzanka Feb 21, 2024

mmusich Feb 21, 2024 •

edited

Loading

grzanka Feb 22, 2024

cmsbuild commented Feb 21, 2024

grzanka commented Feb 21, 2024

grzanka commented Feb 21, 2024

mmusich commented Feb 21, 2024 •

edited

Loading

grzanka commented Feb 21, 2024

mmusich commented Feb 26, 2024

cmsbuild commented Feb 26, 2024

perrotta commented Feb 27, 2024

grzanka commented Mar 1, 2024

mmusich commented Mar 1, 2024

subirsarkar commented Mar 1, 2024

saumyaphor4252 commented Mar 4, 2024

AdrianoDee commented Mar 4, 2024

cmsbuild commented Mar 4, 2024

antoniovilela commented Mar 4, 2024

[PPS] Added gtStage2DigisAlCaRecoProducer to ALCARECOPRODUCER #44044

[PPS] Added gtStage2DigisAlCaRecoProducer to ALCARECOPRODUCER #44044

Conversation

grzanka commented Feb 21, 2024

PR description:

PR validation:

Backward compatibility

HLT test file production recipe

cmsbuild commented Feb 21, 2024 • edited Loading

cmsbuild commented Feb 21, 2024

cmsbuild commented Feb 21, 2024

saumyaphor4252 commented Feb 21, 2024

mmusich commented Feb 21, 2024

saumyaphor4252 commented Feb 21, 2024

saumyaphor4252 commented Feb 21, 2024 • edited Loading

saumyaphor4252 commented Feb 21, 2024

missirol Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmusich Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Feb 21, 2024

Comparison Summary

grzanka commented Feb 21, 2024

grzanka commented Feb 21, 2024

mmusich commented Feb 21, 2024 • edited Loading

grzanka commented Feb 21, 2024

mmusich commented Feb 26, 2024

cmsbuild commented Feb 26, 2024

Comparison Summary

perrotta commented Feb 27, 2024

grzanka commented Mar 1, 2024

mmusich commented Mar 1, 2024

subirsarkar commented Mar 1, 2024

saumyaphor4252 commented Mar 4, 2024

AdrianoDee commented Mar 4, 2024

cmsbuild commented Mar 4, 2024

antoniovilela commented Mar 4, 2024

cmsbuild commented Feb 21, 2024 •

edited

Loading

saumyaphor4252 commented Feb 21, 2024 •

edited

Loading

missirol Feb 21, 2024 •

edited

Loading

mmusich Feb 21, 2024 •

edited

Loading

mmusich commented Feb 21, 2024 •

edited

Loading