Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2024 MC GTs with the L1 menu L1Menu_Collisions2024_v1_0_1_xml #44389

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Mar 13, 2024

PR description:

Update the 2024 MC GTs with the new L1 menu as in cmsTalk https://cms-talk.web.cern.ch/t/update-of-the-2024-l1-menu-tag-l1menu-collisions2024-v1-0-1/36759

The updated tag for L1TUtmTriggerMenuRcd is
From: L1Menu_Collisions2024_v1_0_0_xml
To: L1Menu_Collisions2024_v1_0_1_xml

GT differences

PR validation:

This must be tested (and merged) together with #44054
bot tests with the former Candidate GTs, identical to the versioned GTs now in the PR, were succesful, see #44054 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported

This will have to be backported in 14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44389/39450

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@consuegs, @cmsbuild, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@fabiocos, @missirol, @rsreds, @mmusich, @tocheng, @yuanchao, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor

please test

@mmusich
Copy link
Contributor

mmusich commented Mar 13, 2024

@cmsbuild, please abort

@mmusich
Copy link
Contributor

mmusich commented Mar 13, 2024

@saumyaphor4252 please re-read #44054 (comment) :)

@Martin-Grunewald
Copy link
Contributor

Just a heads up, we'd need a backport to 14_0 as well. Thanks you!

@mmusich
Copy link
Contributor

mmusich commented Mar 14, 2024

@cms-sw/alca-l2 as #44054 is looking conveged, can you provide versioned full-fledged GlobalTags here?

@perrotta
Copy link
Contributor Author

perrotta commented Mar 14, 2024

@perrotta
Copy link
Contributor Author

please test with #44054

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44389/39469

@cmsbuild
Copy link
Contributor

Pull request #44389 was updated. @perrotta, @consuegs, @saumyaphor4252 can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97c3de/38120/summary.html
COMMIT: f9ce6b7
CMSSW: CMSSW_14_1_X_2024-03-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44389/38120/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297383
  • DQMHistoTests: Total failures: 17
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297346
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

perrotta commented Mar 14, 2024

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44054

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with #44054, please check if they should be merged together

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ea6fa8f into cms-sw:master Mar 14, 2024
11 checks passed
@perrotta perrotta deleted the updateL1MenuInGt branch March 19, 2024 10:54
mmusich added a commit to mmusich/cmssw that referenced this pull request Mar 19, 2024
mmusich added a commit to mmusich/cmssw that referenced this pull request Mar 19, 2024
cmsbuild added a commit that referenced this pull request Mar 20, 2024
artlbv added a commit to artlbv/cmssw that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants