Improve error handling in GPU callbacks

[fwyzard]

PR description:

Update the callbacks used on the CUDA and HIP/ROCm backends to match the original CUDA implementation: in case of asynchronous errors, throw-catch an exception to let GDB intercept it, and propagate the exception to the framework.

PR validation:

Unit tests ran.

Backport status

To be backported to 14.0.x for data taking (see #44477)

[fwyzard]

enable gpu

[fwyzard]

please test

[fwyzard]

@makortel, what do you think ?

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44476/39560

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44476/39560/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44476/39560/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[makortel]

what do you think ?

Looks good, thanks. My only comment is that the string formatting could use fmt::format() instead of std::ostringstream, but that's minor.

[fwyzard]

My only comment is that the string formatting could use fmt::format() instead of std::ostringstream, but that's minor.

I thought about it, but that would add a dependency on fmt to HeterogeneousCore/AlpakaInterface, and so potentially to the DataFormats.

If that is OK, I can make the change.

[makortel]

My only comment is that the string formatting could use fmt::format() instead of std::ostringstream, but that's minor.

I thought about it, but that would add a dependency on fmt to HeterogeneousCore/AlpakaInterface, and so potentially to the DataFormats.

If that is OK, I can make the change.

It's ok. DataFormats already depend on fmt transitively via FWCore/MessageLogger.

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44476/39590

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• HeterogeneousCore/AlpakaCore (heterogeneous)
• HeterogeneousCore/AlpakaInterface (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks.
@missirol, @rovere, @makortel this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

+heterogeneous

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e92bf/38300/summary.html
COMMIT: c435174
CMSSW: CMSSW_14_1_X_2024-03-20-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44476/38300/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 42 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297346
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 48 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 1243
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 38497
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[antoniovilela]

+1