Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PF HF sum energy to reco::Centrality #44518

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

This PR introduce new member variables to the reco::Centrality class storing the sum of HF energy derived using the PF candidates (pdgId 1 and 2) measured in the positive and negative pseudo-rapidity regions. In addition, it adapts the code of HiFJGridEmptyAreaCalculator to handle PF candidates from miniAOD.

PR validation:

Validated using the relval workflow 160

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@mandrenguyen @NiharSaha

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44518/39642

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • DQM/Physics (dqm)
  • DQMOffline/JetMET (dqm)
  • DataFormats/HeavyIonEvent (reconstruction)
  • RecoHI/HiCentralityAlgos (reconstruction)
  • RecoHI/HiJetAlgos (reconstruction)

@mandrenguyen, @nothingface0, @syuvivida, @cmsbuild, @antoniovagnerini, @jfernan2, @tjavaid, @rvenditti can you please review it and eventually sign? Thanks.
@mandrenguyen, @rovere, @jazzitup, @yenjie, @mmarionncern, @schoef, @rappoccio, @gkasieczka, @ahinzmann, @yslai, @rociovilar, @jdolen, @dgulhan, @yetkinyilmaz, @kurtejung, @seemasharmafnal, @missirol, @jdamgov, @mariadalfonso, @nhanvtran this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Mar 25, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d30dcb/38370/summary.html
COMMIT: 28d83e2
CMSSW: CMSSW_14_1_X_2024-03-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44518/38370/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 111 lines to the logs
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297537
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297511
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 21.304 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 140.56,... ): 10.652 KiB Physics/Centrality
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@ashleyahram
Copy link

Hi,
Can we please backport this PR to 132X, too? The HIN GO team wants to integrate the centrality table for 2023 PbPb data once the validation is completed. Could you mention this in the PR description, @stahlleiton, unless you can find any technical issues?

@mandrenguyen
Copy link
Contributor

@ashleyahram We shouldn't change the data format in a closed release. I think you can just rerun the centrality producer in your private branch, there's no need to do this in the main cmssw.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44518/39674

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d30dcb/38426/summary.html
COMMIT: b328705
CMSSW: CMSSW_14_1_X_2024-03-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44518/38426/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 28 lines from the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297857
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297834
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 21.304 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 140.56,... ): 10.652 KiB Physics/Centrality
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

please test workflow 160

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d30dcb/38533/summary.html
COMMIT: b328705
CMSSW: CMSSW_14_1_X_2024-04-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44518/38533/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 69 lines from the logs
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3400054
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3400028
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 31.955999999999996 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 140.56,... ): 10.652 KiB Physics/Centrality
  • Checked 207 log files, 169 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@stahlleiton
Copy link
Contributor Author

@cms-sw/dqm-l2 : please review/sign this PR, thanks

@tjavaid
Copy link

tjavaid commented Apr 3, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants