Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13_3_X] Add use of unsubtracted jets in RecoBTag info producers #44579

Merged
merged 2 commits into from
Apr 5, 2024
Merged

[13_3_X] Add use of unsubtracted jets in RecoBTag info producers #44579

merged 2 commits into from
Apr 5, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

backport of #44422

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@mandrenguyen

@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Mar 31, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2024 •
edited
Loading

A new Pull Request was created by @stahlleiton for CMSSW_13_3_X.

It involves the following packages:

  • RecoBTag/FeatureTools (reconstruction)
  • RecoJets/JetProducers (reconstruction)

@mandrenguyen, @cmsbuild, @jfernan2 can you please review it and eventually sign? Thanks.
@missirol, @schoef, @emilbols, @clelange, @Senphy, @gkasieczka, @AlexDeMoor, @yslai, @Ming-Yan, @AnnikaStein, @andrzejnovak, @jdamgov, @mariadalfonso, @ahinzmann, @nhanvtran, @rappoccio, @hqucms, @demuller, @jdolen, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2024 •
edited
Loading

cms-bot internal usage

@stahlleiton stahlleiton mentioned this pull request Mar 31, 2024
Merged
@mandrenguyen
Copy link
Contributor

backport of #44422

@mandrenguyen
Copy link
Contributor

please test

@mandrenguyen
Copy link
Contributor

type btv

@cmsbuild cmsbuild added the btv label Apr 1, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2f4dd/38526/summary.html
COMMIT: 65fc43b
CMSSW: CMSSW_13_3_X_2024-03-31-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44579/38526/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

+1
No change to reco

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

Pull request has been put on hold by @antoniovilela
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2f4dd/38563/summary.html
COMMIT: e97d847
CMSSW: CMSSW_13_3_X_2024-04-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44579/38563/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 361 lines to the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3364261
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3364232
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1
resign

@antoniovilela
Copy link
Contributor

unhold

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2f4dd/38583/summary.html
COMMIT: e97d847
CMSSW: CMSSW_13_3_X_2024-04-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44579/38583/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9a3c25b into cms-sw:CMSSW_13_3_X Apr 5, 2024
10 checks passed
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2f4dd/38631/summary.html
COMMIT: e97d847
CMSSW: CMSSW_13_3_X_2024-04-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44579/38631/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 192 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3364261
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3364235
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@stahlleiton stahlleiton deleted the UnsubJetsForBTag_CMSSW_13_3_X branch April 5, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok btv fully-signed hlt-approved orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_3_X
Development

Successfully merging this pull request may close these issues.
6 participants
@stahlleiton @cmsbuild @mandrenguyen @antoniovilela @mmusich @rappoccio