store the hltobjects for Mass50 triggers

[pinchunchou]

PR description:

We've encountered an issue with the Mass50 HLT triggers for double electrons (Ele15Ele10GsfMass50, DoubleEle10GsfMass50, and DoubleEle15GsfMass50) in both ppref and HI HLT menus. These HLT triggers are not storing any information in the hltobject trees, even though the events are being triggered. After investigating, we have identified that the problem lies with HLTEgammaCombMassFilter.

I have made some modifications to HLTEgammaCombMassFilter, and now the information is being stored in hltobject.

See slides: https://twiki.cern.ch/twiki/pub/CMS/HLT_HIon_Run3/pinchun20230928.pdf (P.8)

Backport PR:
#44746 (14_0_X)

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44778/40012

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44778/40012/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44778/40012/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[mmusich]

type egamma, bug-fix

[mmusich]

@pinchunchou please apply the code formatting as per
#44778 (comment)

[mmusich]

@pinchunchou this branch still fails the code checks. Please apply the code formatting suggested by the bot at #44778 (comment). Also there is a review in the 14.0.X version, can you please address it and port it also here?

[Martin-Grunewald]

@pinchunchou this PR and its backport to 14_0 seem stuck, please address the comments and update the PRs.

[Martin-Grunewald]

code-checks

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44778/40147

• This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44778/40147/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44778/40147/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[pinchunchou]

Hi @Martin-Grunewald and @mmusich , sorry for the late reply. I have applied the fix on code format in the newest commit. Thanks!

[mmusich]

@pinchunchou, there is a review in the 14.0.X version #44746, can you please address it and port it also here?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44778/40270

• This PR adds an extra 20KB to repository

[pinchunchou]

For this PR you'd need to fix the conflicts as shown above (the file with the customisation code has been changed by some other PR integrated in the meantime).

Thanks for checking. Fixed

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44778/40755

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Aggiornamento efficienze singola traccia #45326

[cmsbuild]

Pull request #44778 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

[Martin-Grunewald]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2bc537/40149/summary.html
COMMIT: 4f67362
CMSSW: CMSSW_14_1_X_2024-06-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44778/40149/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 2660 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345088
• DQMHistoTests: Total failures: 1072
• DQMHistoTests: Total nulls: 4
• DQMHistoTests: Total successes: 3343992
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[Martin-Grunewald]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2bc537/40159/summary.html
COMMIT: 4f67362
CMSSW: CMSSW_14_1_X_2024-06-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44778/40159/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345088
• DQMHistoTests: Total failures: 35
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3345033
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1