Fixes for Alpaka Phase2 Pixel Reco #44874

AdrianoDee · 2024-04-30T09:52:56Z

PR description:

Few fixes for the Alpaka chain for Phase2 Pixel reconstruction:

clusterBinning to be < than 32*32 (warpSize*warpSize for CUDA);
(minimal and applies also to Phase 1) properly size the SiPixelDigisHost buffer in CopyToHost method;
removed all the errors part for Phase 2 clusterizer (not defined at the moment);
fixing ALPAKA_ASSERT_ACC(TrackerTraits::numberOfModules < 2048);.

PR validation:

Running *.402 wfs for Phase 2 conditions (e.g. 25034 TTbar D98 with PU)

cmsbuild · 2024-04-30T09:53:21Z

cms-bot internal usage

AdrianoDee · 2024-04-30T09:55:35Z

type bug-fix

cmsbuild · 2024-04-30T10:03:13Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44874/40132

This PR adds an extra 48KB to repository
Found files with invalid states:
- DataFormats/SiPixelDigiSoA/src/classes_def.xml.generated:
  - Added: 7b2edff
  - Deleted: db65c4c

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44874/40132/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44874/40132/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-04-30T10:13:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44874/40133

This PR adds an extra 40KB to repository

cmsbuild · 2024-04-30T10:14:10Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

DataFormats/SiPixelDigiSoA (reconstruction, heterogeneous)
Geometry/CommonTopologies (geometry)
RecoLocalTracker/SiPixelClusterizer (reconstruction)

@mandrenguyen, @bsunanda, @fwyzard, @mdhildreth, @cmsbuild, @civanch, @Dr15Jones, @jfernan2, @makortel can you please review it and eventually sign? Thanks.
@felicepantaleo, @bsunanda, @gpetruc, @GiacomoSguazzoni, @mtosi, @tvami, @missirol, @dkotlins, @mroguljic, @ferencek, @VourMa, @JanFSchulte, @VinInn, @fabiocos, @threus, @tsusa, @rovere, @mmusich this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2024-04-30T10:17:13Z

enable gpu

AdrianoDee · 2024-04-30T10:19:36Z

test parameters:

enable = gpu
workflows = 29834.402, 29834.403, 29661.402, 29661.403
workflows_gpu = 29834.402, 29834.403, 29834.404, 29661.402, 29661.403
workflow_opts = -w upgrade
workflow_opts_gpu = -w upgrade

AdrianoDee · 2024-04-30T10:19:50Z

Testing with TTbar and NuGun.

AdrianoDee · 2024-04-30T10:20:04Z

please test

DataFormats/SiPixelDigiSoA/src/classes_def.xml

fwyzard · 2024-04-30T10:36:01Z

RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/ClusterChargeCut.h

@@ -111,9 +125,18 @@ namespace pixelClustering {
        for (auto i : cms::alpakatools::independent_group_elements(acc, nclus)) {
          newclusId[i] = ok[i] = (charge[i] >= chargeCut) ? 1 : 0;
          if (0 == ok[i])
-            good = false;
+            good &= false;  //better than simple assignment in case of race?


No, I think that a simple assignment is better, because it does not need to read the old value

Understood, reverting.

About the "in case of race", the good is a local variable, and therefore there should be no data races with it.

cmsbuild · 2024-05-06T11:03:51Z

Pull request #44874 was updated. @mdhildreth, @bsunanda, @civanch, @Dr15Jones, @fwyzard, @cmsbuild, @mandrenguyen, @jfernan2, @makortel can you please check and sign again.

AdrianoDee · 2024-05-06T11:22:32Z

please test

fwyzard · 2024-05-06T11:26:26Z

+heterogeneous

cmsbuild · 2024-05-06T14:51:35Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-045e02/39253/summary.html
COMMIT: d3ab5ba
CMSSW: CMSSW_14_1_X_2024-05-06-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44874/39253/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3364549
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3364522
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 210 log files, 175 edm output root files, 50 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 46 differences found in the comparisons
DQMHistoTests: Total files compared: 5
DQMHistoTests: Total histograms compared: 71813
DQMHistoTests: Total failures: 3629
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 68184
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 4 files compared)
Checked 19 log files, 22 edm output root files, 5 DQM output files
TriggerResults: no differences found

fwyzard · 2024-05-06T14:55:47Z

@AdrianoDee could you open a PR to backport the changes to 14.0.x ?

civanch · 2024-05-06T16:13:27Z

+1

AdrianoDee · 2024-05-07T09:17:04Z

@AdrianoDee could you open a PR to backport the changes to 14.0.x ?

Opened here: #44915.

fwyzard · 2024-05-08T16:11:46Z

@cms-sw/reconstruction-l2 any comments from your side, to this PR or its 14.0.x backport (#44915) ?

mandrenguyen · 2024-05-09T07:26:11Z

+1

cmsbuild · 2024-05-09T07:26:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-05-09T20:36:50Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone Apr 30, 2024

cmsbuild added reconstruction-pending geometry-pending pending-signatures tests-pending orp-pending code-checks-pending heterogeneous-pending trk labels Apr 30, 2024

cmsbuild added the bug-fix label Apr 30, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 30, 2024

AdrianoDee force-pushed the phase2_alpaka_fixes branch from db65c4c to 149acad Compare April 30, 2024 10:08

cmsbuild added code-checks-pending and removed code-checks-rejected labels Apr 30, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 30, 2024

cmsbuild added tests-started and removed tests-pending labels Apr 30, 2024

fwyzard reviewed Apr 30, 2024

View reviewed changes

DataFormats/SiPixelDigiSoA/src/classes_def.xml Outdated Show resolved Hide resolved

fwyzard reviewed Apr 30, 2024

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels May 6, 2024

cmsbuild added tests-started and removed tests-pending labels May 6, 2024

cmsbuild added heterogeneous-approved and removed heterogeneous-pending labels May 6, 2024

cmsbuild added tests-approved and removed tests-started labels May 6, 2024

cmsbuild added geometry-approved and removed geometry-pending labels May 6, 2024

AdrianoDee mentioned this pull request May 7, 2024

[14_0_X] Fixes for Alpaka Phase2 Pixel Reco #44915

Merged

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels May 9, 2024

cmsbuild added orp-approved and removed orp-pending labels May 9, 2024

cmsbuild merged commit b54f95f into cms-sw:master May 9, 2024
15 checks passed

AdrianoDee deleted the phase2_alpaka_fixes branch May 14, 2024 05:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for Alpaka Phase2 Pixel Reco #44874

Fixes for Alpaka Phase2 Pixel Reco #44874

AdrianoDee commented Apr 30, 2024

cmsbuild commented Apr 30, 2024 •

edited

Loading

AdrianoDee commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

AdrianoDee commented Apr 30, 2024

AdrianoDee commented Apr 30, 2024

AdrianoDee commented Apr 30, 2024

AdrianoDee commented Apr 30, 2024

fwyzard Apr 30, 2024

AdrianoDee Apr 30, 2024

makortel Apr 30, 2024

cmsbuild commented May 6, 2024

AdrianoDee commented May 6, 2024

fwyzard commented May 6, 2024

cmsbuild commented May 6, 2024

fwyzard commented May 6, 2024

civanch commented May 6, 2024

AdrianoDee commented May 7, 2024

fwyzard commented May 8, 2024

mandrenguyen commented May 9, 2024

cmsbuild commented May 9, 2024

antoniovilela commented May 9, 2024

Fixes for Alpaka Phase2 Pixel Reco #44874

Fixes for Alpaka Phase2 Pixel Reco #44874

Conversation

AdrianoDee commented Apr 30, 2024

PR description:

PR validation:

cmsbuild commented Apr 30, 2024 • edited Loading

AdrianoDee commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

cmsbuild commented Apr 30, 2024

AdrianoDee commented Apr 30, 2024

AdrianoDee commented Apr 30, 2024

AdrianoDee commented Apr 30, 2024

AdrianoDee commented Apr 30, 2024

fwyzard Apr 30, 2024

Choose a reason for hiding this comment

AdrianoDee Apr 30, 2024

Choose a reason for hiding this comment

makortel Apr 30, 2024

Choose a reason for hiding this comment

cmsbuild commented May 6, 2024

AdrianoDee commented May 6, 2024

fwyzard commented May 6, 2024

cmsbuild commented May 6, 2024

Comparison Summary

GPU Comparison Summary

fwyzard commented May 6, 2024

civanch commented May 6, 2024

AdrianoDee commented May 7, 2024

fwyzard commented May 8, 2024

mandrenguyen commented May 9, 2024

cmsbuild commented May 9, 2024

antoniovilela commented May 9, 2024

cmsbuild commented Apr 30, 2024 •

edited

Loading