[DBG] fix undefined ref errors in L1TMuonOverlapPhase2

[smuzaffar]

This fixes #44946
It also needs cms-sw/cmsdist#9193 for DBG IBs

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44974/40257

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• L1Trigger/L1TMuonOverlapPhase2 (upgrade, l1)

@subirsarkar, @epalencia, @srimanob, @aloeliger, @cmsbuild can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @JanFSchulte, @eyigitba, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cadeb3/39384/summary.html
COMMIT: de96203
CMSSW: CMSSW_14_1_X_2024-05-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44974/39384/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.764.76_ZMuSkim2012D/step2_ZMuSkim2012D.log

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338976
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338956
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mbluj]

@smuzaffar thank you.
I think that all the following three files need similar modifications:

L1Trigger/L1TMuonOverlapPhase2/interface/LutNetworkFixedPointRegression2Outputs.h
L1Trigger/L1TMuonOverlapPhase2/interface/LutNeuronLayerFixedPoint.h
L1Trigger/L1TMuonOverlapPhase2/src/PtAssignmentNNRegression.cc 

Maybe I prepare a PR which will supersede this one?

And a C++ question: is there difference between constexpr static const int and static constexpr int?

[cmsbuild]

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with cms-sw/cmsdist#9193, please check if they should be merged together

[smuzaffar]

Maybe I prepare a PR which will supersede this one?

@mbluj, please go ahead and open PR

[makortel]

And a C++ question: is there difference between constexpr static const int and static constexpr int?

All constexpr variables are also const, so in static constexpr int would be sufficient.

[mbluj]

And a C++ question: is there difference between constexpr static const int and static constexpr int?

All constexpr variables are also const, so in static constexpr int would be sufficient.

Thanks, it is what I supposed. So for compactness it is probably better to use static constexpr int, right? Should I correct it in other PR, #44984?
BTW, this one can be closed as it is superseded by #44984.

[iarspider]

@cmsbuild please close
superseeded by #44984