Introducing `SimOnGen` and `GenOnly` wfs for 2024 and 2026D110 #45005

AdrianoDee · 2024-05-21T10:18:46Z

This PR proposes the addition of:

Sim only step running only the SIM step (to be run on top of GEN);
SimOnGen wfs running the SIM step separated from GEN for 2024 and 2026D110 conditions;
GenOnly wfs running only the GEN step for 2024 and 2026D110 conditions.

As a bonus the ALCA input for "upgrade" workflows is updated in order to be more general and to take the output of the RECO step rather than being hardcoded to be step3.root.

These are useful for us (PdmV) e.g.:

to run RelVal jobs recycling only the GEN rerunning the SIM. This will help when we have changes in simulation (e.g. changes in Phase2 geometries) than needs to be validated allowing us to reduce the statistical fluctuations recycling the underlying GEN.
to run GEN only wfs (for MinBias, or default samples) without having to act manually on each workflow.

PR Validation

Running, e.g., 15824.0 and 15634.0.

cmsbuild · 2024-05-21T10:19:08Z

cms-bot internal usage

cmsbuild · 2024-05-21T10:23:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45005/40287

This PR adds an extra 76KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Introducing DIGInoHLT + HLTOnly Steps #44964, Add D110 Default Input Dataset #44965
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532, add Era_Run3_2024, Era_Run3_2025, Tier0 reco scenario for 2024, and change default era in PyReleaseValidation #43761, Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964, introducing BigPixel for phase-2 InnerTracker in T39 geometry #44576, first release of TICLv5 #44785, Introducing DIGInoHLT + HLTOnly Steps #44964

cmsbuild · 2024-05-21T10:23:50Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@srimanob, @cmsbuild, @sunilUIET, @miquork, @AdrianoDee, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2024-05-21T10:29:08Z

test parameters:

workflows=15824.0,15634.0
workflow_opts = -w upgrade

AdrianoDee · 2024-05-21T10:29:13Z

please test

cmsbuild · 2024-05-21T12:35:49Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbc0ba/39443/summary.html
COMMIT: a327e4a
CMSSW: CMSSW_14_1_X_2024-05-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45005/39443/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

15824.0

----- Begin Fatal Exception 21-May-2024 14:26:00 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'pathALCARECOEcalESAlign'
   [2] Calling method for module TrackSelector/'esSelectedTracks'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<reco::Track>
Looking for module label: generalTracks
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

AdrianoDee · 2024-05-21T14:27:49Z

Note: I've added a note in the description about the needed update to the ALCA input coming from RECO step (hardcoded in master, generalized in this PR).

cmsbuild · 2024-05-21T14:33:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45005/40291

This PR adds an extra 64KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Introducing DIGInoHLT + HLTOnly Steps #44964, Add D110 Default Input Dataset #44965
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532, add Era_Run3_2024, Era_Run3_2025, Tier0 reco scenario for 2024, and change default era in PyReleaseValidation #43761, Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964, introducing BigPixel for phase-2 InnerTracker in T39 geometry #44576, first release of TICLv5 #44785, Introducing DIGInoHLT + HLTOnly Steps #44964

cmsbuild · 2024-05-21T14:34:15Z

Pull request #45005 was updated. @cmsbuild, @subirsarkar, @sunilUIET, @miquork, @AdrianoDee, @srimanob can you please check and sign again.

AdrianoDee · 2024-05-21T14:35:07Z

please test

AdrianoDee · 2024-06-06T09:31:56Z

please test

cmsbuild · 2024-06-06T09:40:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45005/40497

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): 2024 Data RelVals and InputInfo Events Skimming (actually) Working #45055
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532, add Era_Run3_2024, Era_Run3_2025, Tier0 reco scenario for 2024, and change default era in PyReleaseValidation #43761, Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964, first release of TICLv5 #44785, Alpaka implementation of Hcal Local Reconstruction (Mahi) #44910, CMSSW Integration of LST #45117

cmsbuild · 2024-06-06T09:40:24Z

Pull request #45005 was updated. @sunilUIET, @srimanob, @subirsarkar, @AdrianoDee, @miquork can you please check and sign again.

cmsbuild · 2024-06-06T12:27:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbc0ba/39748/summary.html
COMMIT: 1250f1d
CMSSW: CMSSW_14_1_X_2024-06-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45005/39748/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338974
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338948
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

AdrianoDee · 2024-06-06T13:05:47Z

+pdmv
(new wfs run as expected)

srimanob · 2024-06-07T14:27:50Z

+Upgrade

cmsbuild · 2024-06-07T14:28:10Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-06-12T01:34:19Z

+1

smuzaffar · 2024-06-13T07:49:21Z

@AdrianoDee , workflow 105.0 is failing in IB [a]. May be change in this PR has broken it? Can you lease check

[a] https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/relVal/CMSSW_14_1/2024-06-12-2300?selectedArchs=el8_amd64_gcc12&selectedFlavors=X&selectedStatus=failed

usage: cmsDriver.py <TYPE> [options].
Example:

cmsDriver.py reco -s RAW2DIGI,RECO --conditions STARTUP_V4::All --eventcontent RECOSIM
cmsDriver.py: error: argument --filein: expected one argument

smuzaffar · 2024-06-13T08:42:18Z

I have proposed a fix #45214

srimanob · 2024-07-03T13:39:51Z

Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

@@ -3133,6 +3152,21 @@ def condition(self, fragment, stepList, key, hasHarvest):
        'Era' : 'Phase2C17I13M9',
        'ScenToRun' : ['GenSimHLBeamSpot','DigiTrigger','RecoGlobal', 'HARVESTGlobal', 'ALCAPhase2'],
    },
+    '2026D110GenOnly' : {
+        'Geom' : 'Extended2026D110',
+        'Beamspot' : 'HLLHC',


Hi @AdrianoDee
Just wonder that we will have the right output with this setting of beamspot?

Hi Phat, I see this message only now. Isn't it just dummy it here? I mean: the BS is defined at SIM step no? Or we have something already at GEN step?

Hi @AdrianoDee
Thanks for coming back, I completely forgot about my comment.

process.VtxSmeared is part of process.pgen. So you will get wrong parameters for vertex smearing. Using DBrealisticHLLHC should give you the proper parameter.

process.pgen = cms.Sequence(cms.SequencePlaceholder("randomEngineStateProducer")+process.VertexSmearing+process.GenSmeared+process.GeneInfo+process.genJetMET, process.PPSTransportTask)
and
process.VertexSmearing = cms.Sequence(cms.SequencePlaceholder("VtxSmeared"))

Issue comes from typo. It should be BeamSpot, not Beamspot. With typo, it will pick default BS of 'Gen' which is 2017.

Fix in #45685

Great thanks!

cmsbuild added this to the CMSSW_14_1_X milestone May 21, 2024

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending labels May 21, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 21, 2024

cmsbuild added tests-started and removed tests-pending labels May 21, 2024

cmsbuild added tests-rejected tests-pending code-checks-pending and removed tests-started tests-rejected code-checks-approved labels May 21, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 21, 2024

cmsbuild removed the tests-pending label May 21, 2024

cmsbuild added tests-started code-checks-pending and removed tests-rejected code-checks-approved labels Jun 6, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 6, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 6, 2024

cmsbuild added pdmv-approved and removed pdmv-pending labels Jun 6, 2024

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Jun 7, 2024

cmsbuild added orp-approved and removed orp-pending labels Jun 12, 2024

cmsbuild merged commit 10c5256 into cms-sw:master Jun 12, 2024
12 checks passed

smuzaffar mentioned this pull request Jun 13, 2024

workflow runner: use previous step output as next step input #45214

Merged

srimanob reviewed Jul 3, 2024

View reviewed changes

AdrianoDee deleted the genonly_simongen branch July 14, 2024 15:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introducing `SimOnGen` and `GenOnly` wfs for 2024 and 2026D110 #45005

Introducing `SimOnGen` and `GenOnly` wfs for 2024 and 2026D110 #45005

AdrianoDee commented May 21, 2024 •

edited

Loading

cmsbuild commented May 21, 2024 •

edited

Loading

cmsbuild commented May 21, 2024

cmsbuild commented May 21, 2024

AdrianoDee commented May 21, 2024

AdrianoDee commented May 21, 2024

cmsbuild commented May 21, 2024

AdrianoDee commented May 21, 2024

cmsbuild commented May 21, 2024

cmsbuild commented May 21, 2024

AdrianoDee commented May 21, 2024

AdrianoDee commented Jun 6, 2024

cmsbuild commented Jun 6, 2024

cmsbuild commented Jun 6, 2024

cmsbuild commented Jun 6, 2024

AdrianoDee commented Jun 6, 2024

srimanob commented Jun 7, 2024

cmsbuild commented Jun 7, 2024

rappoccio commented Jun 12, 2024

smuzaffar commented Jun 13, 2024

smuzaffar commented Jun 13, 2024

srimanob Jul 3, 2024

AdrianoDee Aug 10, 2024

srimanob Aug 10, 2024

srimanob Aug 10, 2024

srimanob Aug 10, 2024 •

edited

Loading

srimanob Aug 10, 2024

AdrianoDee Aug 11, 2024

Introducing SimOnGen and GenOnly wfs for 2024 and 2026D110 #45005

Introducing SimOnGen and GenOnly wfs for 2024 and 2026D110 #45005

Conversation

AdrianoDee commented May 21, 2024 • edited Loading

PR Validation

cmsbuild commented May 21, 2024 • edited Loading

cmsbuild commented May 21, 2024

cmsbuild commented May 21, 2024

AdrianoDee commented May 21, 2024

AdrianoDee commented May 21, 2024

cmsbuild commented May 21, 2024

RelVals

AdrianoDee commented May 21, 2024

cmsbuild commented May 21, 2024

cmsbuild commented May 21, 2024

AdrianoDee commented May 21, 2024

AdrianoDee commented Jun 6, 2024

cmsbuild commented Jun 6, 2024

cmsbuild commented Jun 6, 2024

cmsbuild commented Jun 6, 2024

Comparison Summary

AdrianoDee commented Jun 6, 2024

srimanob commented Jun 7, 2024

cmsbuild commented Jun 7, 2024

rappoccio commented Jun 12, 2024

smuzaffar commented Jun 13, 2024

smuzaffar commented Jun 13, 2024

srimanob Jul 3, 2024

Choose a reason for hiding this comment

AdrianoDee Aug 10, 2024

Choose a reason for hiding this comment

srimanob Aug 10, 2024

Choose a reason for hiding this comment

srimanob Aug 10, 2024

Choose a reason for hiding this comment

srimanob Aug 10, 2024 • edited Loading

Choose a reason for hiding this comment

srimanob Aug 10, 2024

Choose a reason for hiding this comment

AdrianoDee Aug 11, 2024

Choose a reason for hiding this comment

Introducing `SimOnGen` and `GenOnly` wfs for 2024 and 2026D110 #45005

Introducing `SimOnGen` and `GenOnly` wfs for 2024 and 2026D110 #45005

AdrianoDee commented May 21, 2024 •

edited

Loading

cmsbuild commented May 21, 2024 •

edited

Loading

srimanob Aug 10, 2024 •

edited

Loading