AMPTInterface: Fix used uninitialized warnings

[smuzaffar]

Fixes #44913
Fixes used uninitialized variable warnings reported by enabling -O3 GEANT4 IBs and GCC13 #44913)

src/GeneratorInterface/AMPTInterface/src/hipyset1.35.f:11352:72:

11352 |             ETARE=ETARE-3.*EJ*VJ*(FXYRE-0.25*F1RE)
      |                                                                        ^
  Warning: 'vj' may be used uninitialized [-Wmaybe-uninitialized]
 src/GeneratorInterface/AMPTInterface/src/hipyset1.35.f:11297:14:

11297 |             VJ=AJ-4.*EJ*XW
      |              ^
note: 'vj' was declared here
src/GeneratorInterface/AMPTInterface/src/hipyset1.35.f:11276:72:

11276 |             ETARE=ETARE+0.5*3.*EJ**2*EPS*(1.+(EPS-1.)*PHIRE)
      |                                                                        ^
  Warning: 'ej' may be used uninitialized [-Wmaybe-uninitialized]
 src/GeneratorInterface/AMPTInterface/src/hipyset1.35.f:11253:14:

11253 |             EJ=KCHG(J,1)/3.
      |              ^
note: 'ej' was declared here

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45020/40311

• This PR adds an extra 140KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• GeneratorInterface/AMPTInterface (generators)

@alberto-sanchez, @bbilin, @menglu21, @cmsbuild, @SiewYan, @mkirsano, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45020/40313

• This PR adds an extra 140KB to repository

[cmsbuild]

Pull request #45020 was updated. @alberto-sanchez, @bbilin, @menglu21, @cmsbuild, @mkirsano, @GurpreetSinghChahal, @SiewYan can you please check and sign again.

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fde00f/39479/summary.html
COMMIT: 4b8a313
CMSSW: CMSSW_14_1_X_2024-05-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45020/39479/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338830
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

please test

[smuzaffar]

@cms-sw/generators-l2 can you please review and sign this. It fixes the compilation warnings in IBs

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fde00f/39561/summary.html
COMMIT: 4b8a313
CMSSW: CMSSW_14_1_X_2024-05-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45020/39561/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338839
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[iarspider]

@cms-sw/generators-l2 gentle ping

[menglu21]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1