-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unpacker for L1T Calo Layer 1 to unpack CICADA #45037
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
55 changes: 55 additions & 0 deletions
55
EventFilter/L1TRawToDigi/plugins/implementations_stage2/CICADAUnpacker.cc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
#include "FWCore/MessageLogger/interface/MessageLogger.h" | ||
#include "EventFilter/L1TRawToDigi/plugins/UnpackerFactory.h" | ||
|
||
#include "CICADAUnpacker.h" | ||
|
||
#include <cmath> | ||
|
||
using namespace edm; | ||
|
||
namespace l1t { | ||
namespace stage2 { | ||
bool CICADAUnpacker::unpack(const Block& block, UnpackerCollections* coll) { | ||
LogDebug("L1T") << "Block Size = " << block.header().getSize(); | ||
LogDebug("L1T") << "Board ID = " << block.amc().getBoardID(); | ||
|
||
auto res = static_cast<CaloLayer1Collections*>(coll)->getCICADABxCollection(); | ||
// default BX range to trigger standard -2 to 2 | ||
// Even though CICADA will never have BX information | ||
// And everything gets put in BX 0 | ||
res->setBXRange(-2, 2); | ||
|
||
int amc_slot = block.amc().getAMCNumber(); | ||
if (not(amc_slot == 7)) { | ||
throw cms::Exception("CICADAUnpacker") | ||
<< "Calo Summary (CICADA) unpacker is unpacking an unexpected AMC. Expected AMC number 7, got AMC number " | ||
<< amc_slot << std::endl; | ||
return false; | ||
} else { | ||
std::vector<uint32_t> cicadaWords = {0, 0, 0, 0}; | ||
//the last 4 words are CICADA words | ||
for (uint32_t i = 2; i < 6; ++i) { | ||
cicadaWords.at(i - 2) = ((block.payload().at(i)) >> 28); | ||
} | ||
|
||
float cicadaScore = convertCICADABitsToFloat(cicadaWords); | ||
res->push_back(0, cicadaScore); | ||
return true; | ||
} | ||
} | ||
|
||
//convert the 4 CICADA bits/words into a proper number | ||
float CICADAUnpacker::convertCICADABitsToFloat(const std::vector<uint32_t>& cicadaBits) { | ||
uint32_t tempResult = 0; | ||
tempResult |= cicadaBits.at(0) << 12; | ||
tempResult |= cicadaBits.at(1) << 8; | ||
tempResult |= cicadaBits.at(2) << 4; | ||
tempResult |= cicadaBits.at(3); | ||
float result = 0.0; | ||
result = (float)tempResult * pow(2.0, -8); | ||
return result; | ||
} | ||
} // namespace stage2 | ||
} // namespace l1t | ||
|
||
DEFINE_L1T_UNPACKER(l1t::stage2::CICADAUnpacker); |
19 changes: 19 additions & 0 deletions
19
EventFilter/L1TRawToDigi/plugins/implementations_stage2/CICADAUnpacker.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
#ifndef EventFilter_L1TRawToDigi_CICADAUnpacker_h | ||
#define EventFilter_L1TRawToDigi_CICADAUnpacker_h | ||
|
||
#include "EventFilter/L1TRawToDigi/interface/Unpacker.h" | ||
#include "CaloLayer1Collections.h" | ||
|
||
namespace l1t { | ||
namespace stage2 { | ||
class CICADAUnpacker : public Unpacker { | ||
public: | ||
bool unpack(const Block& block, UnpackerCollections* coll) override; | ||
|
||
private: | ||
float convertCICADABitsToFloat(const std::vector<uint32_t>&); | ||
}; | ||
} // namespace stage2 | ||
} // namespace l1t | ||
|
||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
EventFilter/L1TRawToDigi/plugins/implementations_stage2/CaloSummaryCollections.cc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
#include "FWCore/Framework/interface/Event.h" | ||
|
||
#include "CaloSummaryCollections.h" | ||
|
||
namespace l1t { | ||
namespace stage2 { | ||
CaloSummaryCollections::~CaloSummaryCollections() { event_.put(std::move(cicadaDigis_)); } | ||
} // namespace stage2 | ||
} // namespace l1t |
23 changes: 23 additions & 0 deletions
23
EventFilter/L1TRawToDigi/plugins/implementations_stage2/CaloSummaryCollections.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
#ifndef EventFilter_L1TRawToDigi_CaloSummaryCollections_h | ||
#define EventFilter_L1TRawToDigi_CaloSummaryCollections_h | ||
|
||
#include "DataFormats/L1CaloTrigger/interface/CICADA.h" | ||
|
||
#include "EventFilter/L1TRawToDigi/interface/UnpackerCollections.h" | ||
|
||
namespace l1t { | ||
namespace stage2 { | ||
class CaloSummaryCollections : public UnpackerCollections { | ||
public: | ||
CaloSummaryCollections(edm::Event& e) | ||
: UnpackerCollections(e), cicadaDigis_(std::make_unique<CICADABxCollection>()){}; | ||
~CaloSummaryCollections() override; | ||
inline CICADABxCollection* getCICADABxCollection() { return cicadaDigis_.get(); }; | ||
|
||
private: | ||
std::unique_ptr<CICADABxCollection> cicadaDigis_; | ||
}; | ||
} // namespace stage2 | ||
} // namespace l1t | ||
|
||
#endif |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be replaced by a simpler implementation, see https://github.com/cms-sw/cmssw/pull/44222/files#r1653052470 .
In fact, it would be better to share the duplicate code between
EventFilter/L1TRawToDigi/plugins/implementations_stage2/CICADAUnpacker.cc
andEventFilter/L1TRawToDigi/plugins/implementations_stage2/CaloSummaryUnpacker.cc
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am working on this this morning, however just for posterity's sake, I will note that the exact bits grabbed are ever so slightly different, being the first 4 bits of the last 4 words for FED 1356, instead of the first 4 bits of the first 4 words for FEDs 1404 & 1405.
In any case, you are entirely correct that this could be simplified down from the ad-hoc first drafts. I can do that for the uGT one while the HLT experts review. I am not sure what happens for this one now.