Updates to `TkAlV0sAnalyzer` and `V0Monitor` #45056

mmusich · 2024-05-27T13:44:05Z

PR description:

This PR updates TkAlV0sAnalyzer: an analyzer that was introduced in #43757 to monitor a new ALCARECO data-tier called TkAlV0s which contains the tracks and associated clusters, etc. from $K^0_s$→ππ and Λ→pπ decays. In order to test the analyzer the unit test Miscellanea is updated.
In the process I provide into 1691312 some basic improvement to the existing V0 monitoring DQM module V0Monitor, mostly a fillDescriptions method.

PR validation:

scram b runtests_Miscellanea runs fine with this PR.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, will be backported to CMSSW_14_0_X for 2024 data-taking validation purposes.

cmsbuild · 2024-05-27T13:44:35Z

cms-bot internal usage

cmsbuild · 2024-05-27T13:50:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45056/40366

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/OfflineValidation/test/TkAlV0sAnalyzer_cfg.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368

cmsbuild · 2024-05-27T13:50:40Z

A new Pull Request was created by @mmusich for master.

It involves the following packages:

Alignment/OfflineValidation (alca)
DQM/TrackingMonitor (dqm)

@perrotta, @tjavaid, @syuvivida, @consuegs, @rvenditti, @antoniovagnerini, @nothingface0, @cmsbuild, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@arossi83, @yuanchao, @tlampen, @threus, @jandrea, @mmusich, @idebruyn, @mtosi, @adewit, @JanFSchulte, @rsreds, @VourMa, @sroychow, @fioriNTU, @VinInn, @tocheng this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

mmusich · 2024-05-27T17:31:38Z

@cmsbuild, please test

cmsbuild · 2024-05-27T18:46:42Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76430b/39554/summary.html
COMMIT: 7f52cc5
CMSSW: CMSSW_14_1_X_2024-05-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45056/39554/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

4.53

----- Begin Fatal Exception 27-May-2024 19:56:59 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=V0Monitor label='KshortMonitoring'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'genericTriggerEventPSet'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

140.023

----- Begin Fatal Exception 27-May-2024 19:57:47 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=V0Monitor label='KshortMonitoringMB'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'genericTriggerEventPSet'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

139.001

----- Begin Fatal Exception 27-May-2024 19:57:49 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=V0Monitor label='KshortMonitoringMB'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'genericTriggerEventPSet'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
138.5138.5_ExpressCollisions2021/step2_ExpressCollisions2021.log

Expand to see more relval errors ...

- added fillDescriptions - const correctness member in initializer list - correct inclusion guards as per coding rule 4.1

cmsbuild · 2024-05-27T20:28:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45056/40374

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/OfflineValidation/test/TkAlV0sAnalyzer_cfg.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368

cmsbuild · 2024-05-27T20:57:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45056/40377

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Alignment/OfflineValidation/test/TkAlV0sAnalyzer_cfg.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368

cmsbuild · 2024-05-27T20:57:35Z

Pull request #45056 was updated. @antoniovagnerini, @cmsbuild, @perrotta, @nothingface0, @saumyaphor4252, @syuvivida, @consuegs, @tjavaid, @rvenditti can you please check and sign again.

mmusich · 2024-05-28T04:50:09Z

@cmsbuild, please test

cmsbuild · 2024-05-28T09:15:55Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76430b/39559/summary.html
COMMIT: 21a0fec
CMSSW: CMSSW_14_1_X_2024-05-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45056/39559/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3445370
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3445344
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 206 log files, 170 edm output root files, 49 DQM output files
TriggerResults: no differences found

perrotta · 2024-05-28T12:08:48Z

+alca

mmusich · 2024-06-04T00:13:33Z

ping @cms-sw/dqm-l2

tjavaid · 2024-06-04T07:18:26Z

+1

cmsbuild · 2024-06-04T07:18:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mmusich · 2024-06-05T18:56:05Z

@cms-sw/orp-l2 kind ping on this PR

antoniovilela · 2024-06-05T19:53:21Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone May 27, 2024

cmsbuild added dqm-pending alca-pending pending-signatures tests-pending orp-pending code-checks-pending tracking trk labels May 27, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 27, 2024

cmsbuild added tests-started and removed tests-pending labels May 27, 2024

cmsbuild added tests-rejected and removed tests-started labels May 27, 2024

mmusich added 2 commits May 27, 2024 21:55

update TkAlV0sAnalyzer with basic monitoring

bd61d99

basic improvements in V0Monitor

7243f78

- added fillDescriptions - const correctness member in initializer list - correct inclusion guards as per coding rule 4.1

mmusich force-pushed the mm_dev_TkAlV0sAnalyzerUpdates branch from 7f52cc5 to 3c0442f Compare May 27, 2024 20:23

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels May 27, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 27, 2024

cmsbuild added the code-checks-pending label May 27, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 27, 2024

cmsbuild added tests-started and removed tests-pending labels May 28, 2024

cmsbuild added tests-approved and removed tests-started labels May 28, 2024

cmsbuild added alca-approved and removed alca-pending labels May 28, 2024

cmsbuild removed dqm-pending pending-signatures labels Jun 4, 2024

cmsbuild added dqm-approved fully-signed labels Jun 4, 2024

cmsbuild added orp-approved and removed orp-pending labels Jun 5, 2024

cmsbuild merged commit 0666285 into cms-sw:master Jun 5, 2024
11 checks passed

mmusich deleted the mm_dev_TkAlV0sAnalyzerUpdates branch June 5, 2024 19:54

mmusich mentioned this pull request Jun 5, 2024

[14.0.X] Updates to TkAlV0sAnalyzer and V0Monitor #45149

Merged

This was referenced Jun 6, 2024

scram tool clean; support for building stack without an option tool cms-sw/cmsdist#9218

Merged

Fix maybe-uninitialized warning in SeedingTrackFeatures #45152

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to `TkAlV0sAnalyzer` and `V0Monitor` #45056

Updates to `TkAlV0sAnalyzer` and `V0Monitor` #45056

mmusich commented May 27, 2024 •

edited

Loading

cmsbuild commented May 27, 2024 •

edited

Loading

cmsbuild commented May 27, 2024

cmsbuild commented May 27, 2024

mmusich commented May 27, 2024

cmsbuild commented May 27, 2024

cmsbuild commented May 27, 2024

cmsbuild commented May 27, 2024

cmsbuild commented May 27, 2024

mmusich commented May 28, 2024

cmsbuild commented May 28, 2024

perrotta commented May 28, 2024

mmusich commented Jun 4, 2024

tjavaid commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

mmusich commented Jun 5, 2024

antoniovilela commented Jun 5, 2024

Updates to TkAlV0sAnalyzer and V0Monitor #45056

Updates to TkAlV0sAnalyzer and V0Monitor #45056

Conversation

mmusich commented May 27, 2024 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented May 27, 2024 • edited Loading

cmsbuild commented May 27, 2024

cmsbuild commented May 27, 2024

mmusich commented May 27, 2024

cmsbuild commented May 27, 2024

RelVals

RelVals-INPUT

cmsbuild commented May 27, 2024

cmsbuild commented May 27, 2024

cmsbuild commented May 27, 2024

mmusich commented May 28, 2024

cmsbuild commented May 28, 2024

Comparison Summary

perrotta commented May 28, 2024

mmusich commented Jun 4, 2024

tjavaid commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

mmusich commented Jun 5, 2024

antoniovilela commented Jun 5, 2024

Updates to `TkAlV0sAnalyzer` and `V0Monitor` #45056

Updates to `TkAlV0sAnalyzer` and `V0Monitor` #45056

mmusich commented May 27, 2024 •

edited

Loading

cmsbuild commented May 27, 2024 •

edited

Loading