Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove leftover printout in GlobalEvFOutputModule #45125

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Jun 3, 2024

PR description:

Addresses #44892 (comment).

Cherry-picked from @Dr15Jones.
f834a20

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

Already backported as part of #44978.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45125/40463

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2024

A new Pull Request was created by @missirol for master.

It involves the following packages:

  • EventFilter/Utilities (daq)

@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Jun 3, 2024

@smorovic

Do you think this leftover printout could be problematic when testing CMSSW_14_0_7_HLTTest_MULTIARCHS online ? I'm just wondering if the HLT log files would become very large.

@smorovic
Copy link
Contributor

smorovic commented Jun 3, 2024

@smorovic

Do you think this leftover printout could be problematic when testing CMSSW_14_0_7_HLTTest_MULTIARCHS online ? I'm just wondering if the HLT log files would become very large.

We should remove it for the final merge into 14_0, but for the test there is no problem.

FUs have 200 GB /var partition, at the output rate of e.g. 30 kHz and 50-100 bytes per line it would take months to fill it up over all machines. Also hltd manages it and removes older or too big files.

@smorovic
Copy link
Contributor

smorovic commented Jun 3, 2024

+daq

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-601468/39678/summary.html
COMMIT: 5f54149
CMSSW: CMSSW_14_1_X_2024-06-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45125/39678/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338833
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@Dr15Jones
Copy link
Contributor

@missirol thanks!

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 17b9046 into cms-sw:master Jun 5, 2024
11 checks passed
@missirol missirol deleted the devel_amend44892_rmCout branch June 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants