Fix deprecated bitwise operations between different enum types in WTableWidget

[iarspider]

PR description:

Fixes the following warnings:

  src/Fireworks/TableWidget/src/FWTableWidget.cc:29:50: warning: bitwise operation between different enumeration types 'ELayoutHints' and 'ETableLayoutHints' is deprecated [-Wdeprecated-enum-enum-conversion]
    29 | static const UInt_t kRowOptions = kLHintsExpandX | kLHintsFillX | kLHintsShrinkX;
      |                                   ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
  src/Fireworks/TableWidget/src/FWTableWidget.cc:30:50: warning: bitwise operation between different enumeration types 'ELayoutHints' and 'ETableLayoutHints' is deprecated [-Wdeprecated-enum-enum-conversion]
    30 | static const UInt_t kColOptions = kLHintsExpandY | kLHintsFillY | kLHintsShrinkY;
      |                                   ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~

PR validation:

Bot tests

[cmsbuild]

cms-bot internal usage

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45131/40471

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Fireworks/TableWidget (visualization)

@makortel, @Dr15Jones, @alja can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1b681/39692/summary.html
COMMIT: 3a7381d
CMSSW: CMSSW_14_1_CPP20_X_2024-06-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45131/39692/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @wddgit Improve behavior after exception in begin/end run transitions #45017
• @cgsavard Bin L1 track quality MVA variable #45011
• @gpetruc [L1T Phase-2] Correlator Layer 1 pattern file producer updates for multi-board tests #44963
• @AdrianoDee Add D110 Default Input Dataset #44965
• @iarspider [CPP20][Visualisation] Fix deprecated enum bitwise operation in FWCandidateHGCalLegoProxyBuilder #45076
• @Pruthvi-ch Correction to cell shapes for partial wafers in v18 version of HGCal  #45066
• @Dr15Jones Removed duplicate cfi file in L1Trigger/L1CaloTrigger #45094
• @lowette Integration of sexaquark simulation code (for EXO-24-003) #44992
• @iarspider Remove unused constants in CondCore/EcalPlugins/plugins/Ecal*_PayloadInspector.cc #45096
• @iarspider [CPP20][Visualization] Remove deprecated implicit capture of this in FWTEveViewer #45078

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1b681/39692/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c1b681/39692/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoPPSLocalNewT2 had ERRORS

Comparison Summary

Summary:

• You potentially added 2429 lines to the logs
• Reco comparison results: 131 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 908
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3337934
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

ignore tests-rejected with ib-failure

[antoniovilela]

+1