-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New APE measurement workflow #45156
New APE measurement workflow #45156
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45156/40500
|
A new Pull Request was created by @mteroerd for master. It involves the following packages:
@saumyaphor4252, @perrotta, @consuegs, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
…nded example config.yaml
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45156/40524
|
Pull request #45156 was updated. @saumyaphor4252, @cmsbuild, @perrotta, @consuegs can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc7613/39796/summary.html Comparison SummarySummary:
|
@mteroerd this PR adds new test configs: is any unit test foreseen with them? |
I think that these configs would not work in a unit test, as they'd require access to dasgoclient. I agree it makes sense to include a unit test for the new work flow, but since I am short on time to work on this much more and because my contract will end this month, this will probably be a task for my successor, along with the inclusion of a few more features that would make sense. |
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
4ec9659 : Added new workflow for measuring APE using DAGMan and HTCondor.
To execute, run, e.g., "python3 apeMeasurement.py -c mc_example.yaml" (should use el8 for this dataset).
fddb4bd : Removing obsolete files that are not used. Mostly old plotting scripts in macros/.
e75e715 : Removing some references to obsolete files.
PR validation:
Ran the workflow with several different configurations. Also replicated a previous MC 2023 APE campaign (as configured in mc_example.yaml) in order to ensure the same results.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, not sure if backports will be needed (probably not).