Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New APE measurement workflow #45156

Merged
merged 4 commits into from
Jun 12, 2024
Merged

New APE measurement workflow #45156

merged 4 commits into from
Jun 12, 2024

Conversation

mteroerd
Copy link
Contributor

@mteroerd mteroerd commented Jun 6, 2024

PR description:

4ec9659 : Added new workflow for measuring APE using DAGMan and HTCondor.
To execute, run, e.g., "python3 apeMeasurement.py -c mc_example.yaml" (should use el8 for this dataset).

fddb4bd : Removing obsolete files that are not used. Mostly old plotting scripts in macros/.

e75e715 : Removing some references to obsolete files.

PR validation:

Ran the workflow with several different configurations. Also replicated a previous MC 2023 APE campaign (as configured in mc_example.yaml) in order to ensure the same results.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not sure if backports will be needed (probably not).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45156/40500

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

A new Pull Request was created by @mteroerd for master.

It involves the following packages:

  • Alignment/APEEstimation (alca)

@saumyaphor4252, @perrotta, @consuegs, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @missirol, @yuanchao, @rsreds, @adewit, @tocheng this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45156/40524

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

Pull request #45156 was updated. @saumyaphor4252, @cmsbuild, @perrotta, @consuegs can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Jun 8, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc7613/39796/summary.html
COMMIT: 6afe75b
CMSSW: CMSSW_14_1_X_2024-06-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45156/39796/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338974
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338948
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

@mteroerd this PR adds new test configs: is any unit test foreseen with them?

@mteroerd
Copy link
Contributor Author

@mteroerd this PR adds new test configs: is any unit test foreseen with them?

I think that these configs would not work in a unit test, as they'd require access to dasgoclient. I agree it makes sense to include a unit test for the new work flow, but since I am short on time to work on this much more and because my contract will end this month, this will probably be a task for my successor, along with the inclusion of a few more features that would make sense.

@perrotta
Copy link
Contributor

+alca

  • New test configs added, tested and validated under the responsibility of the Alignment/APE group

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2ec4a7d into cms-sw:master Jun 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants