Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default Phase-2 geometry to D110 and restructure relvals_2026 #45175

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Jun 8, 2024

PR description:

Update short and long matrix to D110. I use this chance to restructure relvals_2026, to make it more easy when update the base line.

PR validation:

Test PR config.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No need o f backport. However, we may backport to 14_0 as we also move to D110 in 14_0.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

cms-bot internal usage

@srimanob
Copy link
Contributor Author

srimanob commented Jun 8, 2024

test parameters:

  • workflows = 29634.702,29634.5,29634.9,29634.501,29634.502,29634.21,29696.0,29700.0,29661.0,29861.97,29834.999
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45175/40531

  • This PR adds an extra 24KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

A new Pull Request was created by @srimanob for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@miquork, @AdrianoDee, @sunilUIET, @srimanob, @subirsarkar, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @Martin-Grunewald, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45175/40532

  • This PR adds an extra 24KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

Pull request #45175 was updated. @AdrianoDee, @miquork, @sunilUIET, @cmsbuild, @srimanob, @subirsarkar can you please check and sign again.

@srimanob
Copy link
Contributor Author

srimanob commented Jun 8, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2024

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17a93c/39799/summary.html
COMMIT: 99ba06a
CMSSW: CMSSW_14_1_X_2024-06-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45175/39799/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

----- Begin Fatal Exception 08-Jun-2024 07:29:49 CEST-----------------------
An exception of category 'BtlSimHitsValidation' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step10'
   [2] Calling method for module BtlSimHitsValidation/'btlSimHitsValid'
Exception Message:
GeographicalID: 62800010 (0) is invalid!
----- End Fatal Exception -------------------------------------------------
  • 29634.501A fatal system signal has occurred: abort signal
  • 29634.502A fatal system signal has occurred: abort signal

@srimanob
Copy link
Contributor Author

srimanob commented Jun 8, 2024

As PR test result above:
@cms-sw/mtd-dpg-l2 Could you please have a look on 29634.911 (D110 DD4hep)

[2] Calling method for module BtlSimHitsValidation/'btlSimHitsValid'
Exception Message:
GeographicalID: 62800010 (0) is invalid!

@cms-sw/heterogeneous-l2 @cms-sw/trk-dpg-l2 Could you please have a look on 29634.501 and 29634.502

cmsRun: src/RecoLocalTracker/SiPixelRecHits/src/PixelCPEFast.cc:131: void PixelCPEFast<TrackerTraits>::fillParamsForGpu() [with TrackerTraits = pixelTopology::Phase2]: Assertion `commonParamsGPU_.thePitchY == p.thePitchY' failed.

Thanks very much.

@AdrianoDee
Copy link
Contributor

AdrianoDee commented Jun 8, 2024

@srimanob on the second item see #45177.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17a93c/40016/summary.html
COMMIT: 99ba06a
CMSSW: CMSSW_14_1_X_2024-06-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45175/40016/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

----- Begin Fatal Exception 21-Jun-2024 21:52:58 CEST-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Prefetching for module L1HPSPFTauProducer/'l1tHPSPFTauProducer'
   [4] Prefetching for module L1TPFCandMultiMerger/'l1tLayer1'
   [5] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [6] Prefetching for module PFClusterProducerFromHGC3DClusters/'l1tPFClustersFromHGC3DClusters'
   [7] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 4.55018e+07 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

@srimanob
Copy link
Contributor Author

srimanob commented Jun 22, 2024

@cms-sw/l1-l2 @cms-sw/geometry-l2

Could you please follow the error shown here. It is the same as reported in Issue-41451?

Thx.

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17a93c/40017/summary.html
COMMIT: 99ba06a
CMSSW: CMSSW_14_1_X_2024-06-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45175/40017/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3460538
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460512
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 216 log files, 177 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

+Upgrade

I would propose to merge as is, and follow up the failure workflows:
For pixel track: #45177
For DD4hep: #41451

@AdrianoDee
Copy link
Contributor

+pdmv
Agreeing with the plan

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3d3ceb0 into cms-sw:master Jun 25, 2024
12 checks passed
@srimanob
Copy link
Contributor Author

Note to @cms-sw/reconstruction-l2 @cms-sw/simulation-l2 @cms-sw/geometry-l2 on the update of baseline geometry to D110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants