Cleanup MINI/NANO modifiers

[vlimant]

PR description:

while looking for the proper modifier/era, in preparation for the 10.6 AOD reMINI-reNANO we stumbled upon many outdated process modifier and therefore cleaning them out

• run2_miniAOD_80XLegacy
• run2_miniAOD_94XFall17
• run2_miniAOD_devel
• run3_miniAOD_12X
• miniAOD_UL_preSummer20

[cmsbuild]

cms-bot internal usage

[vlimant]

is there an actual use of run2_miniAOD_80XLegacy run2_miniAOD_94XFall17 ?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45240/40620

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532

[cmsbuild]

A new Pull Request was created by @vlimant for master.

It involves the following packages:

• Configuration/Eras (operations)
• Configuration/StandardSequences (operations)

@davidlange6, @cmsbuild, @fabiocos, @rappoccio, @antoniovilela can you please review it and eventually sign? Thanks.
@rovere, @Martin-Grunewald, @slomeo, @mmusich, @VourMa, @dgulhan, @sameasy, @GiacomoSguazzoni, @JanFSchulte, @felicepantaleo, @mtosi, @makortel, @VinInn, @AnnikaStein, @fabiocos, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[vlimant]

interesting enough, there exists Configuration/ProcessModifiers/python/run2_miniAOD_UL_cff.py already with a similar purpose

This modifier is for common settings to run miniAOD on top of 
ultra-legacy (during LS2) Run-2 AOD

@cms-sw/orp-l2 what is the actual way to implement this : in Eras or ProcessModifiers ?

[vlimant]

could not attend last week ORP, although I left a question there.
@cms-sw/orp-l2 is there a way forward here : Eras or ProcessModifiers ?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45240/40685

• This PR adds an extra 216KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Eras/python/Modifier_run2_miniAOD_80XLegacy_cff.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Configuration/Eras/python/Modifier_run2_miniAOD_94XFall17_cff.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Configuration/Eras/python/Modifier_run2_miniAOD_devel_cff.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532
  • File RecoEgamma/EgammaPhotonProducers/python/reducedEgamma_cfi.py modified in PR(s): Adding in slimmed superclusters for EGM efficiency measurements to Mini #42007

[cmsbuild]

Pull request #45240 was updated. @davidlange6, @mandrenguyen, @fabiocos, @cmsbuild, @hqucms, @ftorrresd, @antoniovilela, @vlimant, @jfernan2, @rappoccio can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45240/40686

• This PR adds an extra 216KB to repository

• Found files with invalid states:

  • Configuration/Eras/python/Modifier_run2_miniAOD_106XUL_cff.py:
    • Added: 8df0152
    • Deleted: 951a99c

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Eras/python/Modifier_run2_miniAOD_80XLegacy_cff.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Configuration/Eras/python/Modifier_run2_miniAOD_94XFall17_cff.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Configuration/Eras/python/Modifier_run2_miniAOD_devel_cff.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Configuration/Eras/python/Modifier_run3_miniAOD_12X_cff.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368
  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532
  • File RecoEgamma/EgammaPhotonProducers/python/reducedEgamma_cfi.py modified in PR(s): Adding in slimmed superclusters for EGM efficiency measurements to Mini #42007

[cmsbuild]

Pull request #45240 was updated. @fabiocos, @davidlange6, @vlimant, @hqucms, @jfernan2, @ftorrresd, @antoniovilela, @rappoccio, @cmsbuild, @mandrenguyen can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45240/40866

• Found files with invalid states:

  • Configuration/Eras/python/Modifier_run2_miniAOD_106XUL_cff.py:
    • Added: bf9d037
    • Deleted: 6a3cde6
  • RecoEgamma/EgammaTools/python/gedGsfElectronsTo106X_cff.py:
    • Deleted: 54f04cd
    • Added: 829152c
  • Configuration/ProcessModifiers/python/run2_miniAOD_UL_preSummer20_cff.py:
    • Deleted: a31c400
    • Added: 563d051

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_standard.py modified in PR(s): 2024 Data RelVals and InputInfo Events Skimming (actually) Working #45055, Update heavy-ion eras for 2024 + add MC RelVal workflows #45307
  • File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): Clean up Phase-2 Geometry D86, D88, D91, D92, D93, D94, D97 #45370
  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532, Update heavy-ion eras for 2024 + add MC RelVal workflows #45307
  • File RecoEgamma/EgammaPhotonProducers/python/reducedEgamma_cfi.py modified in PR(s): Adding in slimmed superclusters for EGM efficiency measurements to Mini #42007

[cmsbuild]

Pull request #45240 was updated. @AdrianoDee, @antoniovagnerini, @antoniovilela, @davidlange6, @fabiocos, @kskovpen, @miquork, @nothingface0, @rappoccio, @rvenditti, @srimanob, @subirsarkar, @sunilUIET, @syuvivida, @tjavaid can you please check and sign again.

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02dadf/40323/summary.html
COMMIT: 563d051
CMSSW: CMSSW_14_1_X_2024-07-09-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45240/40323/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 10 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3431662
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3431639
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 195 log files, 166 edm output root files, 45 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 17023
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 17023
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 57 log files, 34 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.783	2.783	0.000 ( +0.0% )	3.31	3.28	+1.0%	6.020	5.923
2500.001	2.897	2.897	0.000 ( +0.0% )	2.97	2.93	+1.1%	6.388	6.277
2500.002	2.843	2.843	0.000 ( +0.0% )	3.06	3.01	+2.0%	6.340	6.247
2500.01	1.446	1.446	0.000 ( +0.0% )	5.79	5.62	+3.1%	2.304	1.896
2500.011	1.906	1.906	0.000 ( +0.0% )	3.12	3.05	+2.3%	2.438	1.821
2500.012	1.761	1.761	0.000 ( +0.0% )	4.46	4.44	+0.4%	2.358	1.749
2500.1	2.353	2.353	0.000 ( +0.0% )	4.22	4.16	+1.4%	5.963	5.878
2500.2	2.459	2.459	0.000 ( +0.0% )	4.80	4.75	+1.1%	5.937	5.867
2500.21	1.285	1.285	0.000 ( +0.0% )	3.08	3.07	+0.3%	2.291	1.579
2500.211	1.668	1.668	0.000 ( +0.0% )	2.90	2.84	+1.8%	2.354	1.603
2500.3	2.229	2.229	0.000 ( +0.0% )	8.84	8.61	+2.6%	5.899	5.846
2500.301	2.833	2.833	0.000 ( +0.0% )	7.95	7.85	+1.3%	2.430	1.779
2500.31	7.164	7.164	0.000 ( +0.0% )	1.46	1.51	-2.9%	1.713	1.711
2500.311	1.568	1.568	0.000 ( +0.0% )	8.79	8.07	+8.9%	1.057	1.059
2500.312	540.338	540.338	0.000 ( +0.0% )	0.54	0.54	-0.2%	1.659	1.674
2500.313	816.269	816.269	0.000 ( +0.0% )	0.76	0.77	-0.9%	1.648	1.644
2500.32	1.348	1.348	0.000 ( +0.0% )	10.36	10.22	+1.4%	2.362	2.310
2500.321	1.757	1.757	0.000 ( +0.0% )	9.04	9.03	+0.2%	2.389	2.385
2500.322	1.236	1.236	0.000 ( +0.0% )	9.02	8.83	+2.1%	2.216	1.774
2500.323	7.642	7.642	0.000 ( +0.0% )	3.93	3.63	+8.2%	1.911	1.935
2500.324	1.874	1.874	0.000 ( +0.0% )	8.85	9.07	-2.4%	2.133	1.786
2500.325	4.136	4.136	0.000 ( +0.0% )	4.13	4.09	+1.0%	2.145	1.718
2500.326	3.342	3.342	0.000 ( +0.0% )	1.49	1.48	+0.9%	1.782	2.077
2500.327	1.811	1.811	0.000 ( +0.0% )	9.04	8.95	+1.0%	2.295	2.173
2500.328	3.364	3.364	0.000 ( +0.0% )	1.35	1.36	-0.5%	1.835	2.127
2500.4	2.374	2.374	0.000 ( +0.0% )	8.15	8.22	-0.9%	5.321	5.627
2500.401	1.891	1.891	0.000 ( +0.0% )	7.70	7.76	-0.8%	1.846	2.191
2500.402	2.950	2.950	0.000 ( +0.0% )	7.65	7.66	-0.2%	1.842	2.186
2500.403	8.700	8.700	0.000 ( +0.0% )	2.79	2.80	-0.4%	1.980	2.202
2500.404	5.474	5.474	0.000 ( +0.0% )	1.09	1.07	+1.3%	1.864	2.125
2500.405	2.860	2.860	0.000 ( +0.0% )	7.70	7.64	+0.7%	2.210	2.312
2500.406	5.491	5.491	0.000 ( +0.0% )	1.02	1.01	+1.0%	2.323	1.955
2500.5	5.194	5.194	0.000 ( +0.0% )	16.16	15.94	+1.4%	1.478	1.373
2500.51	9.120	9.120	0.000 ( +0.0% )	9.83	9.72	+1.1%	1.477	1.475

[srimanob]

+Upgrade

[AdrianoDee]

+pdmv

[vlimant]

can @cms-sw/dqm-l2 ans @cms-sw/operations-l2 please sign or comment ?

[tjavaid]

+1

[rappoccio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.