Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0] CICADA-uGT emulator additions #45293

Merged
merged 17 commits into from
Jul 1, 2024

Conversation

aloeliger
Copy link
Contributor

PR description:

Backport of #44222

Also backports elements of #43799 (already merged) necessary to get the aforementioned working.

This is being backported to because it may be necessary for online running on the next menu

Original description:

This PR adds the uGT half of the CICADA -> uGT emulator chain. It adds all the pieces needed to parse and compare the new CICADA condition added in uTM v 0.12.0. This is being opened in draft because no unpacker/packer combo is available yet, but will be added after I have had the chance to speak to experts about reading the CICADA record.

Depends on utm version 0.12.0

Note that the unpacker has been added to this PR however.

PR validation:

All code has been validated in the original production release

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport meant for CMSSW_14_0 for online running

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2024

A new Pull Request was created by @aloeliger for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/L1CaloTrigger (l1)
  • EventFilter/L1TRawToDigi (l1)
  • L1Trigger/L1TCaloLayer1 (l1)
  • L1Trigger/L1TGlobal (l1)

@cmsbuild, @aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@dinyar, @Martin-Grunewald, @thomreis, @mmusich, @rovere, @missirol, @eyigitba this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2024

cms-bot internal usage

@aloeliger
Copy link
Contributor Author

Backport of #44222

@aloeliger
Copy link
Contributor Author

please test

@aloeliger
Copy link
Contributor Author

assign hlt

@cmsbuild
Copy link
Contributor

New categories assigned: hlt

@Martin-Grunewald,@mmusich you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3699e2/40050/summary.html
COMMIT: 1e4041d
CMSSW: CMSSW_14_0_X_2024-06-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45293/40050/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 80 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 66 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342458
  • DQMHistoTests: Total failures: 1202
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3341236
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor Author

Recent commits add commits removed by #45294, packaging all commits together, to mirror what was done in #44222

@aloeliger
Copy link
Contributor Author

please test

@aloeliger
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Pull request #45293 was updated. @Martin-Grunewald, @aloeliger, @epalencia, @mmusich can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3699e2/40101/summary.html
COMMIT: 594bb31
CMSSW: CMSSW_14_0_X_2024-06-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45293/40101/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 146 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342528
  • DQMHistoTests: Total failures: 2730
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3339778
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor Author

+l1

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@Martin-Grunewald
Copy link
Contributor

urgent

@cmsbuild cmsbuild added the urgent label Jul 1, 2024
@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5cc9d1a into cms-sw:CMSSW_14_0_X Jul 1, 2024
10 checks passed
This was referenced Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants