Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2024 to the allowed 0T pp collisions workflows (.24 modifier) #45661

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 7, 2024

PR description:

Somewhat inspired by #37820 (comment), add 2024 to the allowed 0T pp collisions workflows (.24 modifier)

PR validation:

runTheMatrix.py --what upgrade -l 12834.24 -t 4 -j 8 --ibeos runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Aug 7, 2024

test parameters:

  • workflows = 12834.24
  • relvals_opt= -w upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45661/41196

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 7, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9ddfd/40818/summary.html
COMMIT: 363b685
CMSSW: CMSSW_14_1_X_2024-08-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45661/40818/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3423977
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3423954
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

+pdmv
(New wf runs smoothly)

@srimanob
Copy link
Contributor

srimanob commented Aug 7, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@srimanob
Copy link
Contributor

srimanob commented Aug 7, 2024

By the way, @mmusich do you remember why you reduced the number of events for 0T to be 1 in #30527 ? Thx.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 7, 2024

do you remember why you reduced the number of events for 0T to be 1 in #30527 ? Thx.

track seeding in collisions at 0T takes an awful amount of time, and limiting the amount of events to 1 guarantees that there aren't timeouts in the IB relvals. Issue #36492 has some details about this.

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fd41c95 into cms-sw:master Aug 7, 2024
12 checks passed
@mmusich mmusich deleted the mm_add_2024_0T_wf branch August 8, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants