Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce RelVal Events for B0ToJpsiK0s_JMM_Filter_DGamma0 #45798

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

AdrianoDee
Copy link
Contributor

PR description:

This PR proposes to reduce the number of default GEN events for B0ToJpsiK0s_JMM_Filter_DGamma0_TuneCP5_13p6TeV
to be processed by the RelVal machine to 18M. As is we produce 38M, that with a 2.8% GEN-efficiency become ~1M. With this statistics we end up having >120k well reconstructed $B^0$.

Screenshot 2024-08-25 alle 21 57 28

With the new setup we should produce >50k clean candidates that should be well enough for a release validation.

PR validation:

None.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2024

cms-bot internal usage

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • workflow_opts= -w upgrade
  • workflows = 12944.81

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals-INPUT
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12da4d/41123/summary.html
COMMIT: bdf77b8
CMSSW: CMSSW_14_1_X_2024-08-25-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45798/41123/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12da4d/41123/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12da4d/41123/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

RelVals-INPUT

  • 2024.2040052024.204005_RunJetMET02024D_50k/step1_dasquery.log
  • 2024.2070052024.207005_RunNoBPTX2024D_50k/step1_dasquery.log
  • 2024.104052024.10405_RunJetMET02024C_500k/step1_dasquery.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 4432 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3495556
  • DQMHistoTests: Total failures: 664
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3494872
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 196 log files, 166 edm output root files, 45 DQM output files
  • TriggerResults: found differences in 2 / 43 workflows

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Aug 27, 2024
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12da4d/41151/summary.html
COMMIT: bdf77b8
CMSSW: CMSSW_14_1_X_2024-08-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45798/41151/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor Author

+pdmv

@AdrianoDee
Copy link
Contributor Author

The DAS query failures are due to the fact that we have not the input GEN-SIM for this fragment.

@srimanob
Copy link
Contributor

srimanob commented Sep 2, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6422269 into cms-sw:master Sep 3, 2024
12 checks passed
@AdrianoDee AdrianoDee deleted the patch-15 branch September 6, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants