[MiniAOD, NanoAOD] Update AK8 subjet b-taggers, add pileup jet ID #46191

nurfikri89 · 2024-10-02T07:24:04Z

PR description:

This PR adds the following in MiniAOD and NanoAOD:

AK8 subjet taggers: Remove DeepCSV and older taggers. Add DeepJet (fallback option) and UParT (latest and greatest).
Pileup Jet ID: Following up PR [JME] Set up Pileup Jet ID for AK4 Puppi V18 jets #46137, now adds Pileup Jet ID discriminant in NanoAOD.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos
passes MiniAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034

cmsbuild · 2024-10-02T07:24:31Z

cms-bot internal usage

cmsbuild · 2024-10-02T07:25:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46191/41991

There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py modified in PR(s): Remove run3_nanoAOD_122 & 124 modifiers #46151
- File PhysicsTools/NanoAOD/python/jetsAK8_cff.py modified in PR(s): Add GloParT inference utility #45830, Remove run3_nanoAOD_122 & 124 modifiers #46151
- File PhysicsTools/NanoAOD/python/nanoDQM_cff.py modified in PR(s): Remove run3_nanoAOD_122 & 124 modifiers #46151
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Boosted DeepTauID v2.0 #46112

cmsbuild · 2024-10-02T07:26:03Z

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)
PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @AnnikaStein, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @demuller, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2024-10-02T08:19:04Z

enable nano

jfernan2 · 2024-10-02T08:19:12Z

enable profiling

jfernan2 · 2024-10-02T08:19:22Z

please test

cmsbuild · 2024-10-02T11:47:33Z

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b57d9/41873/summary.html
COMMIT: 1f30bcc
CMSSW: CMSSW_14_2_X_2024-10-01-2300/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46191/41873/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 48 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331337
DQMHistoTests: Total failures: 3507
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3327810
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3.1010000000000018 KiB( 43 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 0.248 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 2500.201 ): -0.619 KiB Physics/NanoAODDQM
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

hqucms · 2024-10-02T12:07:48Z

enable nano,profiling

hqucms · 2024-10-02T12:10:42Z

please test

hqucms · 2024-10-02T12:34:55Z

PhysicsTools/NanoAOD/python/nanoDQM_cff.py

+    if 'btagDeepFlavB' not in plot.name.value() and 'btagUParTAK4B' not in plot.name.value():
+        _SubJet_pre142X_plots.append(plot)
+_SubJet_pre142X_plots.extend([
+    Plot1D('btagCMVA', 'btagCMVA', 20, -1, 1, 'CMVA V2 btag discriminator'),


Do we have btagCMVA for subjets?

Not anymore. Will remove this.

hqucms · 2024-10-02T12:36:03Z

PhysicsTools/NanoAOD/python/nanoDQM_cfi.py

@@ -817,6 +818,8 @@
                Count1D('_size', 9, -0.5, 8.5, 'slimmedJetsAK8PFPuppiSoftDropPacked::SubJets, i.e. soft-drop subjets for ak8 fat jets for boosted'),
                Plot1D('btagCMVA', 'btagCMVA', 20, -1, 1, 'CMVA V2 btag discriminator'),


I think btagCMVA can be removed.

I will remove this also.

cmsbuild · 2024-10-02T13:37:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46191/42002

There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py modified in PR(s): Remove run3_nanoAOD_122 & 124 modifiers #46151
- File PhysicsTools/NanoAOD/python/jetsAK8_cff.py modified in PR(s): Add GloParT inference utility #45830, Remove run3_nanoAOD_122 & 124 modifiers #46151
- File PhysicsTools/NanoAOD/python/nanoDQM_cff.py modified in PR(s): Remove run3_nanoAOD_122 & 124 modifiers #46151
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Boosted DeepTauID v2.0 #46112

cmsbuild · 2024-10-02T13:37:40Z

Pull request #46191 was updated. @cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please check and sign again.

hqucms · 2024-10-02T13:38:40Z

please abort

hqucms · 2024-10-02T13:39:13Z

please test

cmsbuild · 2024-10-02T17:05:56Z

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b57d9/41884/summary.html
COMMIT: c661187
CMSSW: CMSSW_14_2_X_2024-10-02-1100/el8_amd64_gcc12
Additional Tests: NANO,PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46191/41884/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 111 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331306
DQMHistoTests: Total failures: 3040
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3328246
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.603 KiB( 43 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 0.009 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 2500.201 ): -0.738 KiB Physics/NanoAODDQM
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 1361 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 14 differences found in the comparisons
DQMHistoTests: Total files compared: 21
DQMHistoTests: Total histograms compared: 55016
DQMHistoTests: Total failures: 24
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 54992
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -3.386 KiB( 20 files compared)
DQMHistoSizes: changed ( 2500.001,... ): 0.009 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 2500.101,... ): -0.738 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 2500.111,... ): -0.491 KiB Physics/NanoAODDQM
Checked 102 log files, 58 edm output root files, 21 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	2.941	2.941	-0.000 ( -0.0% )	3.06	3.04	+0.7%	6.064	6.098
2500.002	3.050	3.050	-0.000 ( -0.0% )	2.75	2.74	+0.3%	6.417	6.442
2500.003	2.994	2.995	-0.001 ( -0.0% )	2.85	2.84	+0.1%	6.380	6.400
2500.011	1.534	1.534	-0.000 ( -0.0% )	4.73	4.67	+1.3%	2.421	2.167
2500.012	2.031	2.032	-0.001 ( -0.0% )	2.86	2.86	+0.2%	2.585	2.199
2500.013	1.873	1.873	-0.000 ( -0.0% )	4.08	4.04	+1.0%	2.520	2.221
2500.021	0.022	0.022	0.000 ( +0.0% )	0.92	0.93	-0.3%	2.396	2.362
2500.022	0.022	0.022	0.000 ( +0.0% )	0.91	0.90	+1.4%	2.387	2.353
2500.023	0.022	0.022	-0.000 ( -0.2% )	0.88	0.87	+1.4%	2.256	2.225
2500.024	0.022	0.022	0.000 ( +0.0% )	0.67	0.66	+1.7%	2.479	2.454
2500.031	0.035	0.035	0.000 ( +0.0% )	0.82	0.82	-0.3%	2.455	2.424
2500.032	0.036	0.036	0.000 ( +0.0% )	0.84	0.84	-0.4%	2.420	2.384
2500.033	0.037	0.037	0.000 ( +0.0% )	0.75	0.75	+0.7%	2.504	2.468
2500.034	0.036	0.036	0.000 ( +0.0% )	0.76	0.76	+0.9%	2.469	2.444
2500.101	2.732	2.732	0.000 ( +0.0% )	8.55	8.50	+0.6%	6.340	6.359
2500.111	1.389	1.389	0.000 ( +0.0% )	18.98	18.60	+2.0%	2.246	2.244
2500.112	1.806	1.806	0.000 ( +0.0% )	14.08	14.97	-6.0%	2.324	2.315
2500.131	0.747	0.747	0.000 ( +0.0% )	17.57	17.48	+0.5%	1.417	1.522
2500.201	2.557	2.557	0.000 ( +0.0% )	7.28	7.39	-1.5%	5.619	6.240
2500.211	1.700	1.700	0.000 ( +0.0% )	17.51	17.15	+2.1%	1.995	2.284
2500.212	2.096	2.096	0.000 ( +0.0% )	13.54	13.50	+0.3%	1.981	2.370
2500.221	2.004	2.004	0.000 ( +0.0% )	7.57	7.56	+0.2%	1.991	2.459
2500.222	3.281	3.281	0.000 ( +0.0% )	7.32	7.39	-1.0%	1.964	2.543
2500.223	8.968	8.968	0.000 ( +0.0% )	2.59	2.57	+0.8%	2.220	2.576
2500.224	5.787	5.787	0.000 ( +0.0% )	0.60	0.59	+1.2%	2.242	2.603
2500.225	5.805	5.805	0.000 ( +0.0% )	0.58	0.57	+0.9%	2.261	2.624
2500.226	3.044	3.044	0.000 ( +0.0% )	7.29	7.19	+1.5%	2.535	2.540
2500.227	1.437	1.437	0.000 ( +0.0% )	11.45	11.29	+1.5%	1.437	1.434
2500.231	1.404	1.404	0.000 ( +0.0% )	13.55	13.61	-0.4%	2.184	2.189
2500.232	2.301	2.301	0.000 ( +0.0% )	13.58	13.51	+0.5%	2.277	2.281
2500.233	4.748	4.748	0.000 ( +0.0% )	4.18	4.14	+1.0%	2.288	2.300
2500.234	3.501	3.501	0.000 ( +0.0% )	0.76	0.76	+0.2%	2.069	2.313
2500.235	3.513	3.513	0.000 ( +0.0% )	0.74	0.74	-0.1%	2.091	2.330
2500.236	2.145	2.145	0.000 ( +0.0% )	13.78	13.42	+2.7%	2.277	2.266
2500.237	1.016	1.016	0.000 ( +0.0% )	16.51	16.48	+0.2%	1.415	1.472
2500.241	9.404	9.404	0.000 ( +0.0% )	3.40	3.30	+3.2%	1.487	1.954
2500.242	10.331	10.331	0.000 ( +0.0% )	0.84	0.84	+0.1%	1.394	1.738
2500.243	2.712	2.712	0.000 ( +0.0% )	7.90	8.03	-1.6%	1.070	1.082
2500.244	485.976	485.976	0.000 ( +0.0% )	0.54	0.53	+1.9%	1.689	1.679
2500.245	823.202	823.202	0.000 ( +0.0% )	0.72	0.71	+1.6%	1.667	1.688
2500.901	1.777	1.777	0.000 ( +0.0% )	20.54	20.42	+0.6%	1.852	1.852
2500.902	1.626	1.626	0.000 ( +0.0% )	20.15	19.75	+2.0%	1.775	1.775
2500.911	13.995	13.995	0.000 ( +0.0% )	3.61	2.99	+20.6%	1.101	1.100
2500.912	0.240	0.150	0.090 ( +59.9% )	1.49	1.30	+14.3%	0.974	0.984
2500.913	0.110	0.110	0.000 ( +0.0% )	1.09	1.03	+6.5%	0.984	0.984

hqucms · 2024-10-02T17:25:58Z

+1

jfernan2 · 2024-10-02T18:33:16Z

+1

cmsbuild · 2024-10-02T18:33:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-10-02T19:16:45Z

+1

nurfikri89 added 5 commits October 2, 2024 09:01

Remove old b-taggers for AK8 subjets. Add DeepJet and UParT.

b5d8e5f

Remove DeepCSV for AK8 subjets and add DeepJet and UParT

63ee5e9

Add Pileup Jet ID discriminant for AK4 Puppi jets

9af26c3

Update nanoDQM for subjet b-taggers and Pileup Jet ID for AK4 Puppi jets

3fcd3cc

Delete commented line

1f30bcc

cmsbuild added this to the CMSSW_14_2_X milestone Oct 2, 2024

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Oct 2, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 2, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 2, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 2, 2024

cmsbuild added tests-started and removed tests-approved labels Oct 2, 2024

hqucms reviewed Oct 2, 2024

View reviewed changes

cmsbuild added tests-pending code-checks-pending and removed code-checks-approved labels Oct 2, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 2, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 2, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 2, 2024

cmsbuild added xpog-approved and removed xpog-pending labels Oct 2, 2024

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Oct 2, 2024

cmsbuild added orp-approved and removed orp-pending labels Oct 2, 2024

cmsbuild merged commit a2883eb into cms-sw:master Oct 2, 2024
15 checks passed

cmsbuild mentioned this pull request Oct 2, 2024

[NanoAOD] Add ParticleNet-based Muon ID #46153

Open

iarspider mentioned this pull request Oct 3, 2024

UnknownUserFloat exception: Requested UserFloat pileupJetIdPuppi:fullDiscriminant is not available #46221

Closed

nurfikri89 mentioned this pull request Oct 3, 2024

[JMENano] Setup Pileup Jet ID for reclustered AK4 Puppi jets #46244

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MiniAOD, NanoAOD] Update AK8 subjet b-taggers, add pileup jet ID #46191

[MiniAOD, NanoAOD] Update AK8 subjet b-taggers, add pileup jet ID #46191

nurfikri89 commented Oct 2, 2024

cmsbuild commented Oct 2, 2024 •

edited

Loading

cmsbuild commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

jfernan2 commented Oct 2, 2024

jfernan2 commented Oct 2, 2024

jfernan2 commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

hqucms commented Oct 2, 2024

hqucms commented Oct 2, 2024

hqucms Oct 2, 2024

nurfikri89 Oct 2, 2024

hqucms Oct 2, 2024

nurfikri89 Oct 2, 2024

cmsbuild commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

hqucms commented Oct 2, 2024

hqucms commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

hqucms commented Oct 2, 2024

jfernan2 commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

mandrenguyen commented Oct 2, 2024

		@@ -817,6 +818,8 @@
		Count1D('_size', 9, -0.5, 8.5, 'slimmedJetsAK8PFPuppiSoftDropPacked::SubJets, i.e. soft-drop subjets for ak8 fat jets for boosted'),
		Plot1D('btagCMVA', 'btagCMVA', 20, -1, 1, 'CMVA V2 btag discriminator'),

[MiniAOD, NanoAOD] Update AK8 subjet b-taggers, add pileup jet ID #46191

[MiniAOD, NanoAOD] Update AK8 subjet b-taggers, add pileup jet ID #46191

Conversation

nurfikri89 commented Oct 2, 2024

PR description:

PR validation:

cmsbuild commented Oct 2, 2024 • edited Loading

cmsbuild commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

jfernan2 commented Oct 2, 2024

jfernan2 commented Oct 2, 2024

jfernan2 commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

Comparison Summary

hqucms commented Oct 2, 2024

hqucms commented Oct 2, 2024

hqucms Oct 2, 2024

Choose a reason for hiding this comment

nurfikri89 Oct 2, 2024

Choose a reason for hiding this comment

hqucms Oct 2, 2024

Choose a reason for hiding this comment

nurfikri89 Oct 2, 2024

Choose a reason for hiding this comment

cmsbuild commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

hqucms commented Oct 2, 2024

hqucms commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

Comparison Summary

NANO Comparison Summary

hqucms commented Oct 2, 2024

jfernan2 commented Oct 2, 2024

cmsbuild commented Oct 2, 2024

mandrenguyen commented Oct 2, 2024

cmsbuild commented Oct 2, 2024 •

edited

Loading