Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BTVNano] add NegTag for UParT #46288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Ming-Yan
Copy link
Contributor

@Ming-Yan Ming-Yan commented Oct 7, 2024

PR description:

Add Negative tag of UParT and deduced the output node to btvnano

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

cms-bot internal usage

@Ming-Yan Ming-Yan changed the title feat: add NegTag for UParT [BTVNano] add NegTag for UParT Oct 7, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46288/42110

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

A new Pull Request was created by @Ming-Yan for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (xpog, reconstruction)
  • RecoBTag/ONNXRuntime (reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @AnnikaStein, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @missirol, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@ftorrresd
Copy link
Contributor

enable nano

@ftorrresd
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c94a69/42023/summary.html
COMMIT: 0bdf08d
CMSSW: CMSSW_14_2_X_2024-10-07-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46288/42023/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially removed 1200 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 55028
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 55028
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 2.949 2.949 0.000 ( +0.0% ) 3.03 3.04 -0.2% 6.054 6.061
2500.002 3.059 3.059 0.000 ( +0.0% ) 2.70 2.72 -0.6% 6.400 6.402
2500.003 3.003 3.003 0.000 ( +0.0% ) 2.83 2.84 -0.4% 6.511 6.385
2500.011 1.534 1.534 0.000 ( +0.0% ) 4.67 4.67 -0.1% 2.421 2.420
2500.012 2.031 2.031 0.000 ( +0.0% ) 2.85 2.85 -0.0% 2.584 2.608
2500.013 1.873 1.873 0.000 ( +0.0% ) 4.06 4.04 +0.6% 2.518 2.518
2500.021 0.022 0.022 0.000 ( +0.0% ) 0.92 0.94 -3.0% 2.381 2.385
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.90 0.90 -0.8% 2.381 2.371
2500.023 0.022 0.022 0.000 ( +0.0% ) 0.89 0.89 -0.3% 2.242 2.245
2500.024 0.022 0.022 0.000 ( +0.0% ) 0.67 0.67 -0.3% 2.483 2.471
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.82 0.81 +0.9% 2.438 2.446
2500.032 0.036 0.036 0.000 ( +0.0% ) 0.83 0.85 -2.1% 2.406 2.420
2500.033 0.037 0.037 0.000 ( +0.0% ) 0.75 0.74 +2.2% 2.493 2.489
2500.034 0.036 0.036 0.000 ( +0.0% ) 0.75 0.76 -0.3% 2.467 2.465
2500.101 2.732 2.732 0.000 ( +0.0% ) 8.43 8.46 -0.3% 6.335 6.956
2500.111 1.389 1.389 0.000 ( +0.0% ) 19.10 19.24 -0.7% 2.239 2.233
2500.112 1.806 1.806 0.000 ( +0.0% ) 14.72 14.53 +1.3% 2.017 2.310
2500.131 0.747 0.747 0.000 ( +0.0% ) 17.35 17.27 +0.4% 1.409 1.502
2500.201 2.557 2.557 0.000 ( +0.0% ) 7.36 7.23 +1.8% 5.609 6.233
2500.211 1.700 1.700 0.000 ( +0.0% ) 17.21 17.06 +0.8% 2.024 2.279
2500.212 2.096 2.096 0.000 ( +0.0% ) 13.56 13.65 -0.7% 2.102 2.363
2500.221 2.004 2.004 0.000 ( +0.0% ) 7.58 7.47 +1.4% 2.197 2.448
2500.222 3.281 3.281 0.000 ( +0.0% ) 7.12 7.37 -3.3% 2.281 2.535
2500.223 9.290 8.968 0.322 ( +3.6% ) 1.80 2.57 -29.8% 2.241 2.566
2500.224 5.815 5.815 0.000 ( +0.0% ) 0.59 0.59 -0.8% 2.105 2.384
2500.225 5.833 5.833 0.000 ( +0.0% ) 0.57 0.57 -0.5% 2.065 2.383
2500.226 3.044 3.044 0.000 ( +0.0% ) 7.15 7.21 -0.8% 1.951 2.532
2500.227 1.437 1.437 0.000 ( +0.0% ) 11.28 11.15 +1.1% 1.397 1.436
2500.231 1.404 1.404 0.000 ( +0.0% ) 13.47 13.41 +0.4% 1.983 2.180
2500.232 2.301 2.301 0.000 ( +0.0% ) 13.55 12.96 +4.6% 2.264 2.272
2500.233 4.845 4.748 0.097 ( +2.0% ) 2.75 4.09 -32.9% 2.070 2.280
2500.234 3.518 3.518 0.000 ( +0.0% ) 0.75 0.74 +0.9% 2.064 2.074
2500.235 3.530 3.530 0.000 ( +0.0% ) 0.74 0.73 +0.5% 2.087 2.095
2500.236 2.145 2.145 0.000 ( +0.0% ) 13.49 13.28 +1.6% 1.993 2.274
2500.237 1.016 1.016 0.000 ( +0.0% ) 14.80 16.36 -9.5% 0.985 1.467
2500.241 9.404 9.404 0.000 ( +0.0% ) 3.56 3.63 -1.9% 1.943 1.949
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.85 0.84 +1.8% 1.733 1.732
2500.243 2.712 2.712 0.000 ( +0.0% ) 8.19 7.84 +4.5% 1.076 1.078
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.53 0.52 +1.2% 1.691 1.670
2500.245 823.202 823.202 0.000 ( +0.0% ) 0.71 0.70 +1.3% 1.656 1.678
2500.901 1.777 1.777 0.000 ( +0.0% ) 20.37 19.06 +6.9% 1.839 1.842
2500.902 1.626 1.626 0.000 ( +0.0% ) 19.39 19.31 +0.4% 1.770 1.772
2500.911 13.995 13.995 0.000 ( +0.0% ) 3.25 3.19 +1.8% 1.098 1.097
2500.912 0.310 0.240 0.070 ( +29.3% ) 1.52 1.45 +5.4% 0.976 0.975
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.12 1.09 +2.3% 0.977 0.974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants