Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD] Add UParT electron and muon raw scores #46299

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

nurfikri89
Copy link
Contributor

PR description:

This PR adds the electron and muon UParT raw scores in NanoAOD.

PR validation:

  • passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos
  • passes MiniAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46299/42120

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Oct 8, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Oct 8, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2024

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26ac45/42048/summary.html
COMMIT: 8305d95
CMSSW: CMSSW_14_2_X_2024-10-07-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46299/42048/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 87 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331004
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3330978
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 16.331000000000003 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 1.316 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.791 KiB Physics/NanoAODDQM
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 232 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 54982
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 54982
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 12.117000000000003 KiB( 20 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 1.316 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 0.791 KiB Physics/NanoAODDQM
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 2.976 2.947 0.029 ( +1.0% ) 3.05 3.06 -0.3% 6.052 6.048
2500.002 3.086 3.056 0.029 ( +1.0% ) 2.75 2.74 +0.4% 6.519 6.405
2500.003 3.028 2.998 0.029 ( +1.0% ) 2.81 2.87 -2.1% 6.385 6.374
2500.011 1.554 1.533 0.021 ( +1.4% ) 4.73 4.74 -0.3% 2.427 2.421
2500.012 2.059 2.030 0.029 ( +1.4% ) 2.87 2.88 -0.4% 2.599 2.606
2500.013 1.893 1.872 0.022 ( +1.2% ) 4.07 4.06 +0.2% 2.516 2.515
2500.021 0.022 0.022 0.000 ( +0.0% ) 0.94 0.93 +0.6% 2.378 2.380
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.89 0.89 +0.9% 2.377 2.373
2500.023 0.022 0.022 0.000 ( +0.0% ) 0.86 0.89 -3.5% 2.251 2.248
2500.024 0.022 0.022 0.000 ( +0.0% ) 0.66 0.67 -0.2% 2.465 2.470
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.82 0.82 +0.6% 2.449 2.451
2500.032 0.036 0.036 0.000 ( +0.0% ) 0.83 0.84 -1.6% 2.413 2.406
2500.033 0.037 0.037 0.000 ( +0.0% ) 0.76 0.73 +2.9% 2.494 2.489
2500.034 0.036 0.036 0.000 ( +0.0% ) 0.76 0.75 +1.3% 2.466 2.467
2500.101 2.731 2.728 0.003 ( +0.1% ) 8.47 8.63 -1.9% 6.952 6.324
2500.111 1.389 1.386 0.003 ( +0.2% ) 18.53 18.93 -2.1% 2.229 2.231
2500.112 1.806 1.803 0.002 ( +0.1% ) 14.34 14.61 -1.9% 2.306 2.301
2500.131 0.747 0.747 0.000 ( +0.0% ) 17.37 17.69 -1.8% 1.504 1.493
2500.201 2.553 2.552 0.002 ( +0.1% ) 7.26 7.16 +1.5% 6.237 5.605
2500.211 1.718 1.699 0.019 ( +1.1% ) 17.12 17.61 -2.8% 2.280 2.279
2500.212 2.112 2.095 0.017 ( +0.8% ) 13.45 13.90 -3.2% 2.365 2.361
2500.221 1.998 1.998 0.000 ( +0.0% ) 7.14 7.58 -5.7% 2.452 2.446
2500.222 3.279 3.276 0.003 ( +0.1% ) 7.40 7.34 +0.8% 2.536 2.529
2500.223 8.966 8.963 0.003 ( +0.0% ) 2.55 2.60 -2.2% 2.560 2.559
2500.224 5.863 5.810 0.054 ( +0.9% ) 0.59 0.60 -1.1% 2.420 2.207
2500.225 5.881 5.827 0.054 ( +0.9% ) 0.58 0.58 +0.1% 2.433 2.220
2500.226 3.041 3.038 0.003 ( +0.1% ) 7.24 7.28 -0.7% 2.535 2.539
2500.227 1.437 1.437 0.000 ( +0.0% ) 11.22 11.36 -1.2% 1.427 1.430
2500.231 1.403 1.403 0.000 ( +0.0% ) 12.96 13.64 -4.9% 2.187 2.178
2500.232 2.317 2.300 0.017 ( +0.7% ) 13.06 13.25 -1.4% 2.270 2.275
2500.233 4.764 4.747 0.017 ( +0.4% ) 4.08 4.17 -2.2% 2.291 2.025
2500.234 3.550 3.518 0.032 ( +0.9% ) 0.67 0.75 -11.2% 2.063 2.063
2500.235 3.562 3.530 0.032 ( +0.9% ) 0.73 0.75 -1.8% 2.087 2.071
2500.236 2.162 2.145 0.017 ( +0.8% ) 13.61 13.03 +4.4% 2.274 1.800
2500.237 1.016 1.016 0.000 ( +0.0% ) 15.17 16.14 -6.0% 1.485 1.458
2500.241 9.404 9.404 0.000 ( +0.0% ) 3.55 3.34 +6.3% 1.945 1.944
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.84 0.84 +0.4% 1.732 1.733
2500.243 2.712 2.712 0.000 ( +0.0% ) 7.82 7.33 +6.7% 1.074 1.077
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.53 0.53 +1.2% 1.674 1.664
2500.245 823.202 823.202 0.000 ( +0.0% ) 0.71 0.70 +0.6% 1.656 1.655
2500.901 1.777 1.777 0.000 ( +0.0% ) 20.31 18.06 +12.4% 1.842 1.842
2500.902 1.626 1.626 0.000 ( +0.0% ) 20.62 20.49 +0.6% 1.773 1.766
2500.911 13.995 13.995 0.000 ( +0.0% ) 3.47 3.25 +6.8% 1.096 1.093
2500.912 0.199 0.437 -0.237 ( -54.3% ) 1.17 1.18 -1.2% 0.977 0.976
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.06 1.05 +1.5% 0.979 0.978

@hqucms
Copy link
Contributor

hqucms commented Oct 14, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 232d939 into cms-sw:master Oct 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants