Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRO] adding new PPS conditions for 2023 #46331

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[PRO] adding new PPS conditions for 2023 #46331

wants to merge 3 commits into from

Conversation

diemort
Copy link
Contributor

@diemort diemort commented Oct 10, 2024 •
edited
Loading

This PR is meant to introduce the latest PPS conditions for 2023 for the PPS fast simulation (Direct Simulation).

PPS direct simulation with 2023 conditions show the expected agreement in proton reconstruction based on the gen v recpo comparison.

Gen_vs_Reco_2023

Not a back-port; a new PR is going to be submitted meant for 14.1 since that was the release for 2023 data-taking.

PR passed unittests and runTheMatrix 44 43 41 36 19 1 1 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 0 failed

FYI @fabferro @AndreaBellora @forthommel

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Oct 10, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 10, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46331/42164

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @diemort for master.

It involves the following packages:

  • CalibPPS/ESProducers (alca)
  • Configuration/Eras (operations)
  • Configuration/StandardSequences (operations)
  • SimPPS/Configuration (simulation)
  • SimPPS/DirectSimProducer (simulation)
  • Validation/CTPPS (dqm)

@antoniovagnerini, @antoniovilela, @atpathak, @civanch, @cmsbuild, @consuegs, @davidlange6, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @nothingface0, @perrotta, @rappoccio, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@AnnikaStein, @GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabferro, @fabiocos, @felicepantaleo, @forthommel, @grzanka, @makortel, @missirol, @mmusich, @mtosi, @rovere, @rsreds, @sameasy, @slomeo, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Oct 10, 2024

please test

@smuzaffar
Copy link
Contributor

please test

@makortel
Copy link
Contributor

Is there a plan to get these data into the CondDB? (just curious)

@smuzaffar
Copy link
Contributor

please test

@diemort
Copy link
Contributor Author

diemort commented Oct 10, 2024

Is there a plan to get these data into the CondDB? (just curious)

@makortel indeed, we had this discussion in cms-data. Therre are a few conditions that need to be moved to DB, however the old version of direct simulation is based on local conditions especially Run2. We're working on a validation procedure and can investigate about moving all conditions to DB.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-552d71/42108/summary.html
COMMIT: d222849
CMSSW: CMSSW_14_2_X_2024-10-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46331/42108/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_23_setup had ERRORS

RelVals

----- Begin Fatal Exception 10-Oct-2024 18:26:54 CEST-----------------------
An exception of category 'LogicalFileNameNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
Exception Message:
RootFileSequenceBase::initTheFile()
Logical file name '++ echo /store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root' was not found in the file catalog.
If you wanted a local file, you forgot the 'file:' prefix
before the file name in your configuration file.
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 10-Oct-2024 18:27:03 CEST-----------------------
An exception of category 'LogicalFileNameNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
Exception Message:
RootFileSequenceBase::initTheFile()
Logical file name '++ echo /store/data/Run2016B/SinglePhoton/RAW/v2/000/274/199/00000/CA646D43-8526-E611-A6D9-02163E014300.root' was not found in the file catalog.
If you wanted a local file, you forgot the 'file:' prefix
before the file name in your configuration file.
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 10-Oct-2024 18:27:05 CEST-----------------------
An exception of category 'LogicalFileNameNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
Exception Message:
RootFileSequenceBase::initTheFile()
Logical file name '++ echo /store/data/Commissioning2021/MinimumBias/RAW/v1/000/346/512/00000/be4e0e99-6d25-4b6f-8648-1adefb79c7bf.root' was not found in the file catalog.
If you wanted a local file, you forgot the 'file:' prefix
before the file name in your configuration file.
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 4.174.17_RunMinBias2011A/step2_RunMinBias2011A.log
  • 4.264.26_ZMuSkim2011A/step2_ZMuSkim2011A.log
  • 4.274.27_ZElSkim2011A/step2_ZElSkim2011A.log
Expand to see more relval errors ...

@diemort
Copy link
Contributor Author

diemort commented Oct 10, 2024

the fails seem to be in the wf

@smuzaffar
Copy link
Contributor

please test

there was bug in cms-bot which is fix now

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals
Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-552d71/42113/summary.html
COMMIT: d222849
CMSSW: CMSSW_14_2_X_2024-10-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46331/42113/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_23_setup had ERRORS

RelVals

----- Begin Fatal Exception 10-Oct-2024 21:58:08 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PPSSimTrackProducer label='LHCTransport'
Exception Message:
MissingParameter: Parameter 'TransportMethod' not found.
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 10-Oct-2024 22:03:26 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PPSSimTrackProducer label='LHCTransport'
Exception Message:
MissingParameter: Parameter 'TransportMethod' not found.
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 10-Oct-2024 22:03:37 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PPSSimTrackProducer label='LHCTransport'
Exception Message:
MissingParameter: Parameter 'TransportMethod' not found.
----- End Fatal Exception -------------------------------------------------

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46331/42177

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

Pull request #46331 was updated. @antoniovagnerini, @antoniovilela, @atpathak, @civanch, @cmsbuild, @consuegs, @davidlange6, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @nothingface0, @perrotta, @rappoccio, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@diemort
Copy link
Contributor Author

diemort commented Oct 10, 2024

Regarding the error in the RelVal above, it may be related to the missing era in case the fix in the wf was related to a modification in Era_Run3_2023.

@AndreaBellora
Copy link
Contributor

Is there a plan to get these data into the CondDB? (just curious)

@makortel indeed, we had this discussion in cms-data. Therre are a few conditions that need to be moved to DB, however the old version of direct simulation is based on local conditions especially Run2. We're working on a validation procedure and can investigate about moving all conditions to DB.

Adding a comment on this point: having these conditions in the DB is not straightforward as it sounds. Since our detector and reconstruction changes conditions very often, we came up some years ago with the implementation of the so-called profiles, which are sets of conditions (not supplied from the DB) between which the direct simulation switches when changing lumisections.
A good example is the beam crossing angle: LHC doesn't keep a constant crossing angle, thus we need to simulate events that vary it accordingly. In RECO, we rely on a per-LS payload that replicates the real LHC conditions, and in the simulation this is achieved by extracting the values from the xangle distributions observed in data. If we had to put that into condDB, we would then need a way to simulate different runs and LS so that in the end we reproduce the same xangle distributions.
This, AFAIK, is not obvious and very error-prone, so either we keep using locally supplied files, or we would need to implement records dedicated to the simulation, which somehow contain the profiles, and modify our RECO to treat them properly.
This doesn't only apply to the xangle, but also to a few other conditions that would require a similar treatment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending code-checks-approved dqm-pending operations-pending orp-pending pending-signatures simulation-pending tests-pending
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
6 participants
@diemort @cmsbuild @civanch @smuzaffar @makortel @AndreaBellora