Backport fixes for cms #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please test |
vepadulano
force-pushed
the
backport-fixes-for-cms
branch
from
33307cb
to
583c720
Compare
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/v6-30-00-patches/0541c6f. @iarspider, @aandvalenzuela, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
vepadulano
force-pushed
the
backport-fixes-for-cms
branch
from
583c720
to
4504241
Compare
|
Pull request #195 was updated. |
|
please test |
The llvm9 JIT issued callbacks when a symbol was missing and we reacted on it by loading the relevant library. In root-project/root@9b2041e3 we have kept the logic but now the JIT started querying more often even for symbols which are okay to be missing. In turn that leads to scanning all libraries causing performance issues. This patch tries to limit this functionality only in contexts where automatic loading is allowed.
Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch>
Symbol lookup is a quite expensive operation and might result in JIT compilation and library loading. Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch>
This reverts commit 329fb5a.
This allows us to avoid generating symbols in libCore for these constants keeping the same amount of open calls at ROOT startup time.
`TInterpreter::Declare` does not support issuing statements on the global scope, while `TInterpreter::ProcessLine` does. This test was first introduced in a development version of ROOT (6.31), where the upgrade to LLVM16 was already in place. In that scenario, clang supports global scope statements (thanks to changes made for clang-repl). Applying the test to ROOT 6.30 uncovered the problem, since the clang of LLVM13 does not support global scope statements. Fix the test by using `ProcessLine` instead of `Declare` which does the intended thing independently from the ROOT version. Co-authored-by: Vassil Vassilev <vasil.georgiev.vasilev@cern.ch>
vepadulano
force-pushed
the
backport-fixes-for-cms
branch
from
4504241
to
d4f8f6a
Compare
|
Pull request #195 was updated. |
|
please test |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test testAlcaBeamMonitor had ERRORS Comparison SummarySummary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.