Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: document simplest usage pattern #2638
README: document simplest usage pattern #2638
Changes from 3 commits
84d25b8
4d838ca
9ad70ee
c8d5597
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new added indentations will make it render incorrectly. You can "view file" to see how these are rendered as block quotes now -- clicking it:
Will show the problem:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I was afraid this would be the case — GitHub's preview function didn't work when I tried editing the file in the web interface, so I used a different rST renderer, that indented blockquotes but didn't style them differently from the surrounding text otherwise.
I do think that indenting the text in relation to the associated code block (without marking it as a blockquote) would be ideal in order to convey the proper structure of the document, since in most other cases a code block follows the text that describes it. However, I couldn't figure out a way to simply indent text using rST, so the only other option I can think of is to rephrase these passages so they can be placed before the associated code block. But that would be beyond the scope of this PR, so I'll simply revert those changes. Let me know if you have any other ideas, though!