-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack 5 and Webpacker 6 - Add note that output entry should also not be specified #466
Conversation
I'm upgrading our app to webpacker 6 (webpack 5) and started hitting the snags discussed in #450 The fix was to add the following to the top of our karma.conf.js: ``` const webpackConfig = require('./config/webpack/test.js') // karma watches the test entry points, Do NOT specify the entry option // From https://github.com/ryanclark/karma-webpack#getting-started delete webpackConfig.entry delete webpackConfig.output ```
I tried this but it didn't change the error I get with karma-webpack@next:
|
Open a new issue and post your karma config file! |
Hey @Pezmc, thanks for the PR! I remember reading another issue where it seems there is a certain setup where users expect the output configuration to work. I want to do a little more investigation into this to see if its something we can actually support vs something that needs to be documented. |
I just merged in a PR to the |
@codymikol Which PR is that? I see the warning PR is that what you're referring to? #477 |
That's the one, it has tests proving you can use a custom output path so long as you use the default filename. If you don't use the default name, it yells at you and sets it back to the default. |
This PR contains a:
Motivation / Use-Case
I'm upgrading our app to webpacker 6 (webpack 5) and started hitting the snags discussed in #450 and #452
The fix was to add the following to the top of our karma.conf.js:
As well as:
frameworks: ['jasmine', 'webpack'],
(already covered in docs)watched: false
to files{ pattern: 'spec/javascripts/**/*[sS]pec.js', watched: false },
This PR just adds that note about output to the docs.
Breaking Changes
None
Additional Info
Perhaps an example karma config file for webpacker would also be of value to add to the readme?
For reference a filleted version of ours now looks like: