Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compute=False option to to_snowflake #48

Merged
merged 2 commits into from
May 23, 2023
Merged

Add compute=False option to to_snowflake #48

merged 2 commits into from
May 23, 2023

Conversation

jrbourbeau
Copy link
Member

Users sometimes want finer control over exactly when this compute is triggered. This matches what we do in other to_* methods like to_csv, to_parquet, etc.

@jrbourbeau jrbourbeau mentioned this pull request May 17, 2023
@jrbourbeau
Copy link
Member Author

Will plan to merge in a bit if no further responses. This should be a pretty uncontroversial change.

@dchudz
Copy link

dchudz commented May 23, 2023

@jrbourbeau maybe go ahead and merge now?

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@jrbourbeau
Copy link
Member Author

Thanks for the reminder. Forgot to circle back to this one

@jrbourbeau jrbourbeau merged commit fbfa369 into main May 23, 2023
@jrbourbeau jrbourbeau deleted the compute-falase branch May 23, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants