Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to use uniform styling for class methods #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VIBHOR94
Copy link

@VIBHOR94 VIBHOR94 commented Aug 21, 2024

What changed? Why?

Styling change: Use a uniform way of defining class methods across the codebase.
It is scattered across the codebase using self.method_name or class << self.

All test cases are passing.
No linting issues found.

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Aug 21, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@VIBHOR94 VIBHOR94 force-pushed the uniform-stylng-for-class-methods branch from 8dd7384 to a69ec7c Compare August 25, 2024 05:33
@VIBHOR94 VIBHOR94 force-pushed the uniform-stylng-for-class-methods branch from a69ec7c to 294e8e3 Compare August 25, 2024 06:40
@VIBHOR94 VIBHOR94 marked this pull request as ready for review August 25, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants