Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BigDecimal TokensReader #152

Conversation

KristianLentino99
Copy link
Contributor

@KristianLentino99 KristianLentino99 commented Aug 31, 2024

I was playing around with mainargs for a script of mine and I noticed that there were no implicit for the BigDecimal type. Since I think could be a quite standard type to use I thought about opening this PR also thanks to @lolgab

Pull Request: #152

@lolgab lolgab changed the title Adding BigDecimal TokensReader Add BigDecimal TokensReader Aug 31, 2024
@lolgab lolgab requested a review from lihaoyi August 31, 2024 19:53
Copy link
Member

@lolgab lolgab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lihaoyi lihaoyi merged commit 80ef899 into com-lihaoyi:main Sep 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants