Avoid spurious deprecation warnings in generated code (Backport #3379) #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ihaoyi#3379) Fixes com-lihaoyi#3371 The direct problem is that we are generating code with resolved type aliases, resulting in the `JavaTests` aliases being resolved to deprecated `JavaModuleTests` traits. However, in general generated code should probably not display warnings at all, so better to just slap `@nowarn` on the whole chunk rather than trying to fix the immediate alias resolution problem
lihaoyi
approved these changes
Aug 20, 2024
|
After this PR I think we can release Mill 0.11.12 since the two annoying UX regression are fixed in this PR and in #3393. |
|
Yes feel free to tag it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3371
The direct problem is that we are generating code with resolved type aliases, resulting in the
JavaTestsaliases being resolved to deprecatedJavaModuleTeststraits. However, in general generated code should probably not display warnings at all, so better to just slap@nowarnon the whole chunk rather than trying to fix the immediate alias resolution problemPull Request: #3400