Use portable-scala-reflect instead of the deprecated TestUtils. #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sjrd I have given you commit access to this repo, so feel free to merge this and other PRs yourself once things are green and you're happy with it |
sjrd
force-pushed
the
use-portable-scala-reflect
branch
2 times, most recently
from
930d02b
to
f5d73c2
Compare
`TestUtils` is deprecated in Scala.js 0.6.25. It has been replaced by the more general portable-scala-reflect library. This commit migrates to using the latter. Since portable-scala-reflect does not support Scala Native yet, we need a bit more stuff in `PlatformShims`. These won't be necessary when Scala Native implements scala-native/scala-native#1279 and portable-scala-reflect starts supporting Scala Native.
sjrd
force-pushed
the
use-portable-scala-reflect
branch
from
f5d73c2
to
fe76a02
Compare
|
Rebased after #178 was merged. Should be good now. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestUtilsis deprecated in Scala.js 0.6.25. It has been replaced by the more general portable-scala-reflect library. This commit migrates to using the latter.Since portable-scala-reflect does not support Scala Native yet, we need a bit more stuff in
PlatformShims. These won't be necessary when Scala Native implements scala-native/scala-native#1279 and portable-scala-reflect starts supporting Scala Native.The change in depth of stack traces that are ignored is due to the fact that
TestUtils.loadModulewas a macro that forced inlining of its implementation, whereasPlatformShims.loadModuledoes not do that.