Send offer duration from ASB to CLI #1662
Conversation
ikmckenz
force-pushed
the
transmit-offer-valid-duration
branch
from
17e7858
to
0bf96a8
Compare
|
Yes, that's exactly what I imagined! Making the duration variable can be added at a later point. But unfortunately this is not backwards compatible is it? If it's not possible without introducing a seperate new libp2p protocol I'd suggest we postpone mergin this this until we need to introduce another (more important) breaking network protocol change. What do do you think? |
|
It can probably be made optional and remain backwards compatible? |
|
Perhaps #1268 should be implemented prior to merging |
ikmckenz
force-pushed
the
transmit-offer-valid-duration
branch
from
0bf96a8
to
2106bf8
Compare
On the ASB side this is max_swap_timeout, and may eventually be configurable, or dynamic. On the CLI side this is just received as valid_duration, an Optional Duration. Signed-off-by: Ian McKenzie <sirreal.ian@gmail.com>
ikmckenz
force-pushed
the
transmit-offer-valid-duration
branch
from
2106bf8
to
c600405
Compare
|
Made the valid_duration (the BidQuote part the CLI receives) Optional. Not sure if the the integration tests cover this kind of change that may or may not be backwards compatible. Perhaps additional integration test can be made where one party uses the current code, and the other party pulls the most recent released code from GitHub and runs that? Not sure. |
|
Have you tested manually if this works? |
Eventually I like the idea of this being a "max offer duration", which could be configurable, and then advanced users could have their own variable duration based around things like volatility. But for now I think this accomplishes the goals of #1644 .