Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: show tethering status in sidebar #33786

Merged

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Oct 14, 2024

Displays "Hotspot" and full signal strength in the sidebar when tethering is enabled.

Screenshot from 2024-10-15 01-07-02

To avoid using a long signal-slot chain from WifiManager to the Sidebar for tethering notifications, a cached Networking *networking instance is used in the sidebar class.
Additionally, the previous width of 100px for displaying the network type was insufficient for "Hotspot," so it has been increased to 200px (width() - 100), and left-aligned with the signal strength display. This slightly changes the layout, but the new alignment is more logical. For example, the "Wi-Fi" text previously extended 8 pixels past the left edge of the signal strength, causing misalignment. Now, the alignment is cleaner.

resolve: #33428

@deanlee deanlee changed the title ui: show tethering status on sidebar ui: show tethering status in sidebar Oct 14, 2024
@github-actions github-actions bot added the ui label Oct 14, 2024
Copy link
Contributor

github-actions bot commented Oct 14, 2024

UI Preview

homescreen : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
offroad_alert : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
update_available : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
prime : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_sidebar : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
onroad_wide_sidebar : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
All Screenshots

@deanlee deanlee marked this pull request as ready for review October 14, 2024 17:29
@adeebshihadeh adeebshihadeh merged commit 3c5d8da into commaai:master Oct 14, 2024
26 of 27 checks passed
@deanlee deanlee deleted the ui_sidebar_show_tethering_state branch October 15, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: show full strength wifi for tethering
2 participants