Add supported car for 2019 Toyota Altis Hybrid

[u8511049]

Fingerprint

Toyota-Altis Hybrid-2019

Car support

Toyota-Altis Hybrid-2019

https://my.comma.ai/5ceff72287a5c86c/1571534312818/1571537369543

Cabana
https://my.comma.ai/cabana/?route=5ceff72287a5c86c%7C2019-10-20--09-18-33&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2F5ceff72287a5c86c%2F633c5011c172cc6c8f67084e2903ce1f_2019-10-20--09-18-33&seekTime=0

[u8511049]

Add other links
https://my.comma.ai/5ceff72287a5c86c/1571453941876/1571457352486

https://my.comma.ai/cabana/?route=5ceff72287a5c86c%7C2019-10-19--10-59-02&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2F5ceff72287a5c86c%2F23574dab99ad8a81d33b9ee1e0b223e1_2019-10-19--10-59-02&seekTime=992

[rbiasini]

Thanks! My understanding is that the Altis is the same as the Corolla in the US market., correct? If yes, I would prefer to call it Corolla Hybrid (COROLLAH_TSS2) for consistency with the US market.
Also, do you mind adding the newly supported model to the list in README.md?

[rbiasini]

Also, fingerprint looks good. If you can change the name of the car, then it's good to be merged.

[rbiasini]

Sorry for the back and forth, but thinking about it more, there is no need to separate the Corolla Hybrid from the Corolla ICE (same params). I think all you need is the diff below:

diff --git a/README.md b/README.md
index 64a093261..6748225c6 100644
--- a/README.md
+++ b/README.md
@@ -107,6 +107,7 @@ Supported Cars
 | Toyota               | Corolla 2017-19                    | All                  | Yes     | Yes<sup>2</sup>| 20mph<sup>1</sup>| 0mph           |
 | Toyota               | Corolla 2020                       | All                  | Yes     | Yes            | 0mph             | 0mph           |
 | Toyota               | Corolla Hatchback 2019             | All                  | Yes     | Yes            | 0mph             | 0mph           |
+| Toyota               | Corolla Hybrid 2020                | All                  | Yes     | Yes            | 0mph             | 0mph           |
 | Toyota               | Highlander 2017-19                 | All                  | Yes     | Yes<sup>2</sup>| 0mph             | 0mph           |
 | Toyota               | Highlander Hybrid 2017-19          | All                  | Yes     | Yes<sup>2</sup>| 0mph             | 0mph           |
 | Toyota               | Prius 2016                         | TSS-P                | Yes     | Yes<sup>2</sup>| 0mph             | 0mph           |
diff --git a/selfdrive/car/toyota/values.py b/selfdrive/car/toyota/values.py
index 34060243a..c917f00b8 100644
--- a/selfdrive/car/toyota/values.py
+++ b/selfdrive/car/toyota/values.py
@@ -21,7 +21,7 @@ class CAR:
   HIGHLANDERH = "TOYOTA HIGHLANDER HYBRID 2018"
   AVALON = "TOYOTA AVALON 2016"
   RAV4_TSS2 = "TOYOTA RAV4 2019"
-  COROLLA_TSS2 = "TOYOTA COROLLA TSS2 2019"
+  COROLLA_TSS2 = "TOYOTA COROLLA TSS2 2019"  # includes hybrid models
   LEXUS_ESH_TSS2 = "LEXUS ES 300H 2019"
   SIENNA = "TOYOTA SIENNA XLE 2018"
   LEXUS_IS = "LEXUS IS300 2018"
@@ -173,6 +173,10 @@ class ECU:
   # hatch 2019+ and sedan 2020+
   {
     36: 8, 37: 8, 114: 5, 170: 8, 180: 8, 186: 4, 401: 8, 426: 6, 452: 8, 464: 8, 466: 8, 467: 8, 544: 4, 550: 8, 552: 4, 562: 6, 608: 8, 610: 8, 643: 7, 705: 8, 728: 8, 740: 5, 742: 8, 743: 8, 761: 8, 764: 8, 765: 8, 800: 8, 810: 2, 812: 8, 824: 8, 829: 2, 830: 7, 835: 8, 836: 8, 865: 8, 869: 7, 870: 7, 871: 2, 877: 8, 881: 8, 896: 8, 898: 8, 900: 6, 902: 6, 905: 8, 913: 8, 921: 8, 933: 8, 934: 8, 935: 8, 944: 8, 945: 8, 951: 8, 955: 8, 956: 8, 976: 1, 998: 5, 999: 7, 1000: 8, 1001: 8, 1002: 8, 1014: 8, 1017: 8, 1020: 8, 1041: 8, 1042: 8, 1044: 8, 1056: 8, 1059: 1, 1076: 8, 1077: 8, 1114: 8, 1161: 8, 1162: 8, 1163: 8, 1164: 8, 1165: 8, 1166: 8, 1167: 8, 1172: 8, 1235: 8, 1237: 8, 1279: 8, 1541: 8, 1552: 8, 1553: 8, 1556: 8, 1557: 8, 1568: 8, 1570: 8, 1571: 8, 1572: 8, 1592: 8, 1595: 8, 1649: 8, 1745: 8, 1775: 8, 1779: 8, 1786: 8, 1787: 8, 1788: 8, 1789: 8, 1808: 8, 1809: 8, 1816: 8, 1817: 8, 1840: 8, 1848: 8, 1904: 8, 1912: 8, 1940: 8, 1941: 8, 1948: 8, 1949: 8, 1952: 8, 1960: 8, 1981: 8, 1986: 8, 1990: 8, 1994: 8, 1998: 8, 2004: 8
+  },
+  # 2019 Taiwan Altis Hybrid
+  {
+    36: 8, 37: 8, 166: 8, 170: 8, 180: 8, 295: 8, 296: 8, 401: 8, 426: 6, 452: 8, 466: 8, 467: 8, 550: 8, 552: 4, 560: 7, 562: 6, 581: 5, 608: 8, 610: 8, 643: 7, 713: 8, 728: 8, 740: 5, 742: 8, 743: 8, 761: 8, 765: 8, 800: 8, 810: 2, 829: 2, 830: 7, 835: 8, 836: 8, 865: 8, 869: 7, 870: 7, 871: 2, 877: 8, 881: 8, 885: 8, 896: 8, 898: 8, 918: 7, 921: 8, 944: 8, 945: 8, 950: 8, 951: 8, 953: 8, 955: 8, 956: 8, 971: 7, 975: 5, 987: 8, 993: 8, 1002: 8, 1014: 8, 1017: 8, 1020: 8, 1041: 8, 1042: 8, 1044: 8, 1056: 8, 1057: 8, 1059: 1, 1071: 8, 1082: 8, 1112: 8, 1114: 8, 1161: 8, 1162: 8, 1163: 8, 1172: 8, 1235: 8, 1237: 8, 1279: 8, 1541: 8, 1552: 8, 1553: 8, 1556: 8, 1557: 8, 1568: 8, 1570: 8, 1571: 8, 1572: 8, 1592: 8, 1594: 8, 1595: 8, 1745: 8, 1775: 8, 1779: 8
   }],
   CAR.LEXUS_ESH_TSS2: [
   {

Do you agree? If you make a PR with that I will merge this PR.

[u8511049]

Hi rbiasini,
corolla_tss2 and altish_tss2 have different dbc as below.
CAR.COROLLA_TSS2: dbc_dict('toyota_nodsu_pt_generated', 'toyota_tss2_adas'),
CAR.ALTISH_TSS2: dbc_dict('toyota_nodsu_hybrid_pt_generated', 'toyota_tss2_adas'),
I try to add fingerprint in corolla_tss2 but get an "Communication Issue between processes" error.
I think the different is about the gear. AltisH gear is "P R N D B"

[rbiasini]

Ah, good catch! Can we just call it Toyota Hybrid and add it to the Readme (see my diffs)? Then it's good to go.

[u8511049]

Sure. Thanks for helping.
so, should I close this request?

[rbiasini]

Oh, why closing it? I mean, if you change the car name and add it to the readme I'll merge it in.

[u8511049]

Got it. :)
I had changed the car name and add it to the readme.
Thanks.

[rbiasini]

this should be:

| Toyota               | Toyota Corolla Hybrid 2020      | All                  | Yes     | Yes            | 0mph             | 0mph           | Toyota            |

And placed in alphabetical order in the table (after Corolla Hatchback)

[rbiasini]

this should be
COROLLAH_TSS2 = "TOYOTA COROLLA HYBRID TSS2 2019"

[rbiasini]

Almost. Sorry, I'm not being clear, my fault. See 2 comments in PR

[u8511049]

It's ok.
Please check it.
Thanks.

[rbiasini]

looks good!