Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hook): migrate to TypeScript #1872

Merged
merged 3 commits into from
Apr 28, 2021
Merged

refactor(hook): migrate to TypeScript #1872

merged 3 commits into from
Apr 28, 2021

Conversation

adnasa
Copy link
Contributor

@adnasa adnasa commented Apr 17, 2021

Summary

😬

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2021

🦋 Changeset detected

Latest commit: ecc22ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@commercetools-uikit/hooks Patch
@commercetools-uikit/calendar-utils Patch
@commercetools-uikit/collapsible-motion Patch
@commercetools-uikit/collapsible Patch
@commercetools-uikit/data-table-manager Patch
@commercetools-uikit/data-table Patch
@commercetools-uikit/password-field Patch
@commercetools-uikit/date-input Patch
@commercetools-uikit/date-range-input Patch
@commercetools-uikit/date-time-input Patch
@commercetools-uikit/localized-money-input Patch
@commercetools-uikit/localized-multiline-text-input Patch
@commercetools-uikit/localized-rich-text-input Patch
@commercetools-uikit/localized-text-input Patch
@commercetools-uikit/money-input Patch
@commercetools-uikit/multiline-text-input Patch
@commercetools-uikit/rich-text-input Patch
@commercetools-uikit/time-input Patch
@commercetools-uikit/primary-action-dropdown Patch
@commercetools-uikit/tooltip Patch
@commercetools-frontend/ui-kit Patch
@commercetools-uikit/collapsible-panel Patch
@commercetools-uikit/fields Patch
@commercetools-uikit/date-field Patch
@commercetools-uikit/inputs Patch
@commercetools-uikit/date-range-field Patch
@commercetools-uikit/date-time-field Patch
@commercetools-uikit/localized-multiline-text-field Patch
@commercetools-uikit/localized-text-field Patch
@commercetools-uikit/money-field Patch
@commercetools-uikit/multiline-text-field Patch
@commercetools-uikit/time-field Patch
@commercetools-uikit/rich-text-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/commercetools/ui-kit/Hd8GrakkgCnzwjVK2uWWkRzXgirf
✅ Preview: https://ui-kit-git-adnasa-hooks-typescript-commercetools.vercel.app

Comment on lines +11 to +13
onChange: (
key: TSortDefinition['key'],
order: TSortDefinition['order']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was tempted to update the callback signature but that would be a breaking change. I played around with Types and thought maybe this is a great use case to use function overloads and let the type describe intent with the signature

https://gist.github.com/adnasa/66611e1fb9064074caa2eaf17297562e

@adnasa adnasa removed the request for review from parthikrb April 28, 2021 08:43
@adnasa adnasa enabled auto-merge (squash) April 28, 2021 08:43
@adnasa adnasa merged commit 043e9d2 into main Apr 28, 2021
@adnasa adnasa deleted the adnasa-hooks-typescript branch April 28, 2021 08:50
@ghost ghost mentioned this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants