-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TS config for better dependencies navigation #2457
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Not sure if we need a changeset for this one since we're not changing any of them (or maybe all of them if we look it the other way around). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this change 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Interesting find, thanks! Did you check how the build is affected by this? |
So my idea would be to merge this one and use the canary release to test it in both If you have some ideas where I should put my eye into, please let me know 🙏 |
I'm wondering how is this supposed to work. When we build the packages we generate bundle files and declaration files. The |
Ah! I see. Yes, I didn't realize we don't include source files in the published packages. The ways this works is exactly as you mentioned, mapping files are created for every compiled one.
From the tests I did locally within the So, worst case scenario, if we add this configuration we will be able to navigate to source from within our packages but that will not work from a host package (eg: appkit using uikit), but the experience in this use case would be the same as we currently have (navigate to declarations). Another option would be for us to include source files in the published package. |
Including source files could be an option yes. Should we give this a try? |
Summary
When a user tries to follow one of
ui-kit
dependency from their IDE, it will be redirected to the Typescript types declaration file. We think most of the time this user would like to be redirected to the actual source code file.Description
The idea comes from this tweet where it's suggested to add the
declarationMap
configuration attribute to true.